Skip to content

Deduplicate release-* Pass skip in manual - #2244

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-2177
Nov 15, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-2177

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Deduplicates the release-* Pass-skip rule in the user manual (docs/guide.md) now that Spec #2162 has merged and both candidate-selection paragraphs already describe thirdshift release:

  • Remove the repeated "Review Passes (\review --author`) and Fix Passes skip `release-*` pull requests targeting `main`, leaving their version-only heads to the Release run."sentence fromdocs/guide.md's ### Release safeguards` subsection.
  • Keep Fix Pass (#fix-runs) and Review Pass (#review-runs) candidate selection as the single places in docs/guide.md stating the release-* Pass skip.
  • Reword the remaining explicit thirdshift fix <pr-url> --no-merge --no-base-fix sentence under ### Release safeguards so it reads cleanly on its own ("release bump pull requests targeting \main`", linking #fix-runsand#review-runs), while preserving the Session destructive-command signals` sentence intact.
  • Regenerate site/docs/index.html with npm run docs --prefix site and add a regression test in site/tests/docs.test.cjs asserting that release-* Pass-skip wording appears only in Fix and Review Pass selection while Release safeguards retains the targeted Fix and session-signal guidance.

Closes #2177

Evidence

Execution evidence

Before editing docs/guide.md (new regression test in site/tests/docs.test.cjs failing against the duplicate sentence):

$ node --test --test-name-pattern='release-\* Pass skip' site/tests/docs.test.cjs
✖ the manual states the release-* Pass skip only in Fix and Review candidate selection (10.68706ms)
ℹ tests 1
ℹ suites 0
ℹ pass 0
ℹ fail 1
...
  AssertionError [ERR_ASSERTION]: ../../docs/guide.md: expected release-* skip only in Fix and Review Pass selection
  3 !== 2

After editing docs/guide.md, regenerating site/docs/index.html, and verifying the final repository state:

$ npm run docs:check --prefix site && node --test --test-name-pattern='release-\* Pass skip' site/tests/docs.test.cjs && grep -n 'release-\*' docs/guide.md site/docs/index.html
> docs:check
> node generate-docs.mjs --check

✔ the manual states the release-* Pass skip only in Fix and Review candidate selection (20.004004ms)
ℹ tests 1
ℹ suites 0
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 124.830443
docs/guide.md:3589:`release-*` pull requests targeting `main`, leaving those version bumps to
docs/guide.md:3729:marker posted by the GitHub account thirdshift acts as. It skips `release-*`
site/docs/index.html:3431:<code>release-*</code> pull requests targeting <code>main</code>, leaving those version bumps to
site/docs/index.html:3560:marker posted by the GitHub account thirdshift acts as. It skips <code>release-*</code>

Final scripts/affected-tests main validation run (exit 0, all selected checks passed):

  • npm test --prefix site (68.67s): tests 72, pass 72, fail 0, skipped 0 (docs:check, docs.test.cjs, review-counts.test.cjs, Playwright layout/link/interaction checks in pages.test.cjs).
  • cargo test --test share_card --test site_deploy (184.78s): share_card.rs (4 passed; 0 failed; 0 ignored), site_deploy.rs (7 passed; 0 failed; 0 ignored).
  • cargo test --bin thirdshift prompts_page (132.62s): 14 passed; 0 failed; 0 ignored; 1949 filtered out.

Visual evidence

Captured from site/docs/index.html at /docs/#release-safeguards (auto-unfolded by revealFoldedTarget()):

Viewport Before After
Desktop (1440x900) Before desktop After desktop
Mobile (390x844) Before mobile After mobile
Raw screenshot URLs (desktop & mobile)
  • Desktop Before (1440x900): https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/before-desktop.png
  • Desktop After (1440x900): https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/after-desktop.png
  • Mobile Before (390x844): https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/before-mobile.png
  • Mobile After (390x844): https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/after-mobile.png

Merge Danger

Low. Only docs/guide.md, regenerated site/docs/index.html, and a regression test in site/tests/docs.test.cjs changed; no Rust runtime behavior, CLI flags, GitHub automation, or workflows were altered. npm run docs:check --prefix site and scripts/affected-tests main both pass.

Unaddressed findings

None. Both the Standards review (0 actionable findings) and Spec review (0 actionable findings) completed with zero declined or skipped findings requiring follow-up.

Review coverage — unread changed files: none. Both reviewers inspected docs/guide.md, site/tests/docs.test.cjs, and site/docs/index.html, and verified site/docs/index.html regeneration via npm run docs:check --prefix site.

Built with agy 1.5.2 · gemini-4-hydrogen-xhigh · default effort

Security review outcome

No unaddressed introduced findings.

@JacobStephens2
JacobStephens2 merged commit 2cd6d5a into main Nov 15, 2026
15 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2177 branch November 15, 2026 08:49
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deduplicate the release-PR skip sentences in the guide when Spec #2162 merges

1 participant