Repository navigation
Deduplicate release-* Pass skip in manual - #2244
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicates the
release-*Pass-skip rule in the user manual (docs/guide.md) now that Spec #2162 has merged and both candidate-selection paragraphs already describethirdshift release:"Review Passes (\review --author`) and Fix Passes skip `release-*` pull requests targeting `main`, leaving their version-only heads to the Release run."sentence fromdocs/guide.md's### Release safeguards` subsection.#fix-runs) and Review Pass (#review-runs) candidate selection as the single places indocs/guide.mdstating therelease-*Pass skip.thirdshift fix <pr-url> --no-merge --no-base-fixsentence under### Release safeguardsso it reads cleanly on its own ("release bump pull requests targeting \main`", linking#fix-runsand#review-runs), while preserving theSession destructive-command signals` sentence intact.site/docs/index.htmlwithnpm run docs --prefix siteand add a regression test insite/tests/docs.test.cjsasserting thatrelease-*Pass-skip wording appears only in Fix and Review Pass selection whileRelease safeguardsretains the targeted Fix and session-signal guidance.Closes #2177
Evidence
Execution evidence
Before editing
docs/guide.md(new regression test insite/tests/docs.test.cjsfailing against the duplicate sentence):After editing
docs/guide.md, regeneratingsite/docs/index.html, and verifying the final repository state:Final
scripts/affected-tests mainvalidation run (exit 0, all selected checks passed):npm test --prefix site(68.67s):tests 72,pass 72,fail 0,skipped 0(docs:check,docs.test.cjs,review-counts.test.cjs, Playwright layout/link/interaction checks inpages.test.cjs).cargo test --test share_card --test site_deploy(184.78s):share_card.rs(4 passed; 0 failed; 0 ignored),site_deploy.rs(7 passed; 0 failed; 0 ignored).cargo test --bin thirdshift prompts_page(132.62s):14 passed; 0 failed; 0 ignored; 1949 filtered out.Visual evidence
Captured from
site/docs/index.htmlat/docs/#release-safeguards(auto-unfolded byrevealFoldedTarget()):1440x900)390x844)Raw screenshot URLs (desktop & mobile)
1440x900):https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/before-desktop.png1440x900):https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/after-desktop.png390x844):https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/before-mobile.png390x844):https://gist.githubusercontent.com/JacobStephens2/4b67810f1af92fadabff8ab5163c0594/raw/2cb0595181f6e03127657a9596d35d3244af8859/after-mobile.pngMerge Danger
Low. Only
docs/guide.md, regeneratedsite/docs/index.html, and a regression test insite/tests/docs.test.cjschanged; no Rust runtime behavior, CLI flags, GitHub automation, or workflows were altered.npm run docs:check --prefix siteandscripts/affected-tests mainboth pass.Unaddressed findings
None. Both the Standards review (
0actionable findings) and Spec review (0actionable findings) completed with zero declined or skipped findings requiring follow-up.Review coverage — unread changed files: none. Both reviewers inspected
docs/guide.md,site/tests/docs.test.cjs, andsite/docs/index.html, and verifiedsite/docs/index.htmlregeneration vianpm run docs:check --prefix site.Built with agy 1.5.2 · gemini-4-hydrogen-xhigh · default effort
Security review outcome
No unaddressed introduced findings.