Repository navigation
Animate running Waterfall bars continuously - #2225
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2223
Test seams: the rendered Waterfall and span Peek in Chromium, live Command-record updates delivered through the Console, the browser's Pause motion and reduced-motion preferences, and the served running-bar stylesheet rendered at both track heights across its loop boundary.
Evidence
Execution evidence
node --test --test-name-pattern='running Waterfall stripes animate' console/tests/waterfall.test.cjsfailed:every running tree and Peek bar animates,false !== true.After: the same command passed:
ok 1 - running Waterfall stripes animate in the tree and Peek with motion controls,# pass 1,# fail 0. The three new regressions cover loop geometry, motion controls, and retained bars/animation start times across timer ticks and SSE through completion.node .thirdshift-review-FnBgkk/stripe-loop.cjs, exited 1:The 10px stripe bar jumps at loop wrap: edge delta 126.1, interior rasterization delta 27.6(6px edge delta 123.89).After: the same command exited 0; both heights had
edge: 0, interior: 0. The rendered pixel check is retained inconsole/tests/waterfall.test.cjs.scripts/affected-tests mainselection: build passed (21.62s); all 243 Console tests passed (291.76s); Rust stopped at the host-permission failure below (13.24s). Existing focused Waterfall, span Peek, keyboard, Escape, geometry and Theme regressions also passed. All required CI checks passed on head6c36cf0e, including Console, site, all four Rust partitions, the Rust coverage gate and both release builds;gh pr checks https://github.com/JacobStephens2/thirdshift/pull/2225exited 0.tests/activity_log.rs:386warning-count assertion.cargo test --test activity_log an_activity_log_that_cannot_be_written_is_one_warning_and_changes_nothing_else -- --exactreproduces it alone: expected 1 warning, got 2 because session cleanup also reportscould not read process 3345298's environment: Permission denied (os error 13). No Rust source changed in this PR.Visual evidence
1440×900, live call selected in Waterfall and Peek:
390×844, the same live call with Peek open:
Unaddressed findings
src/console/assets/vendor/idiomorph-0.7.4.min.js, Peek loading insrc/console/assets/console.js, and the span data served bysrc/console/waterfall.rs. Idiomorph receives DOM nodes built withtextContentand fixed attribute names, so it parses no HTML, and the new delegated Peek click handler acts only on the span card'sdata-span-actionanddata-reveal-spanelements.Both independent reviewers read all four changed files, including the final fix. No changed file was left unread; no generated output was excluded. Reports and finding counts are saved in
.thirdshift-review-FnBgkk/.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Console
Running-span rendering and motion; no record-format changes.
Built with codex codex-cli 0.169.0 · gpt-6.1-sol · xhigh