Skip to content

Animate running Waterfall bars continuously - #2225

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-2223
Nov 14, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-2223

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Waterfall / Peek running spans
- static hatching; bars replaced on refresh
+ continuous stripe drift; bars updated in place

Closes #2223

Test seams: the rendered Waterfall and span Peek in Chromium, live Command-record updates delivered through the Console, the browser's Pause motion and reduced-motion preferences, and the served running-bar stylesheet rendered at both track heights across its loop boundary.

Evidence

Execution evidence

  • Before: node --test --test-name-pattern='running Waterfall stripes animate' console/tests/waterfall.test.cjs failed: every running tree and Peek bar animates, false !== true.
    After: the same command passed: ok 1 - running Waterfall stripes animate in the tree and Peek with motion controls, # pass 1, # fail 0. The three new regressions cover loop geometry, motion controls, and retained bars/animation start times across timer ticks and SSE through completion.
  • Before: the Spec review's exact command, node .thirdshift-review-FnBgkk/stripe-loop.cjs, exited 1: The 10px stripe bar jumps at loop wrap: edge delta 126.1, interior rasterization delta 27.6 (6px edge delta 123.89).
    After: the same command exited 0; both heights had edge: 0, interior: 0. The rendered pixel check is retained in console/tests/waterfall.test.cjs.
  • Final scripts/affected-tests main selection: build passed (21.62s); all 243 Console tests passed (291.76s); Rust stopped at the host-permission failure below (13.24s). Existing focused Waterfall, span Peek, keyboard, Escape, geometry and Theme regressions also passed. All required CI checks passed on head 6c36cf0e, including Console, site, all four Rust partitions, the Rust coverage gate and both release builds; gh pr checks https://github.com/JacobStephens2/thirdshift/pull/2225 exited 0.
  • Local Rust validation stops at the unchanged tests/activity_log.rs:386 warning-count assertion. cargo test --test activity_log an_activity_log_that_cannot_be_written_is_one_warning_and_changes_nothing_else -- --exact reproduces it alone: expected 1 warning, got 2 because session cleanup also reports could not read process 3345298's environment: Permission denied (os error 13). No Rust source changed in this PR.

Visual evidence

1440×900, live call selected in Waterfall and Peek:

Before desktop
After desktop

390×844, the same live call with Peek open:

Before mobile
After mobile

Unaddressed findings

  • Standards: none (0 findings).
  • Spec: none (1 finding reproduced, fixed and covered by the retained pixel regression).
  • Security: none (0 introduced findings). The review read all four changed files and the code they rely on: the vendored src/console/assets/vendor/idiomorph-0.7.4.min.js, Peek loading in src/console/assets/console.js, and the span data served by src/console/waterfall.rs. Idiomorph receives DOM nodes built with textContent and fixed attribute names, so it parses no HTML, and the new delegated Peek click handler acts only on the span card's data-span-action and data-reveal-span elements.

Both independent reviewers read all four changed files, including the final fix. No changed file was left unread; no generated output was excluded. Reports and finding counts are saved in .thirdshift-review-FnBgkk/.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Blast Radius: Console

Running-span rendering and motion; no record-format changes.

Built with codex codex-cli 0.169.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit c0b4f35 into main Nov 14, 2026
24 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2223 branch November 14, 2026 15:49
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I don't think the bars on the waterfall view animate when representing work in progress / actively working

1 participant