[JacobStephens2]

Summary

The Console Inbox's Done and Resolved sections now say under their heading what they hold. The help shows when a section is empty and when it has rows, needs no hover, and wraps on phones.

 <details class="group" data-group="done">
   <summary><h3>Done <span class="count">
+  <p class="section-help">Ended within the last 24 hours, with nothing waiting for you.
 <details class="group" data-group="resolved">
   <summary><h3>Resolved <span class="count">
+  <p class="section-help">Older Commands with nothing waiting for you, kept here until their
+     retention period ends. Retention counts from when the Command ended or its waiting work
+     was dealt with: dismissed, settled on GitHub or handed to a later Command on the same
+     issue or pull request. Its length is inbox.days in the owning machine's User config.
+     After it, rows stay in the owning machine's History.

• No length is shown. Each Fleet machine can set its own inbox.days, so the help names the setting instead of a number (a template comment says why).
• Neither text says the run succeeded or asks the Day shift to resolve anything.
• Grouping, section names, navigation and retention behaviour are unchanged. Only the template, the CSS and the docs changed.
• docs/guide.md (and the regenerated site/docs/index.html), site/index.html and console/README.md now describe the help.

Evidence

Execution evidence

• Before: cargo test --test console done_and_resolved on the unchanged template:

  failures:
      inbox::done_and_resolved_say_what_they_hold_whether_empty_or_populated
  test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 338 filtered out
  

  The browser test run against the unpatched binary (THIRDSHIFT_BINARY=<main build> node --test --test-name-pattern="Done and Resolved explain" tests/inbox.test.cjs in console/):

  ✖ Done and Resolved explain themselves on a phone, empty or populated, through live refresh (5110.019885ms)
  ℹ fail 1
  

  After:

  test inbox::done_and_resolved_say_what_they_hold_whether_empty_or_populated ... ok
  test watching::taken_up_boundary_moves_the_row_without_a_file_change ... ok
  test result: ok. 2 passed; 0 failed
  

  ℹ pass 1
  ℹ fail 0
  

  The browser test checks a 390px phone with no horizontal overflow, an empty Resolved, and Done after live refresh adds a row.
• scripts/affected-tests main on d7cd2f7 passed npm test --prefix site, cargo build --locked and npm test --prefix console. Its full cargo test step stopped at this session's 10-minute background limit. I reran cargo test on its own on the same head and it exited 0.

Visual evidence

The fixture has one merged Command that ended now (Done) and one that ended two days ago (Resolved).

Desktop 1440×900, /?section=done:

Desktop 1440×900, /?section=resolved:

Mobile 390×844, /?section=done. The viewport ends at the section heading:

Mobile 390×844, /?section=resolved:

Mobile 390×1400, /?section=resolved, extended to show the help wrapping:

Review

The thirdshift-code-review run against origin/main raised 2 Standards and 2 Spec findings. All four were wording, and all four are fixed in d7cd2f7:

• Standards:
  • "runs" is now "Commands", per the Glossary.
  • console/README.md now mentions the help.
• Spec:
  • site/index.html no longer suggests the UI shows a retention length.
  • The help now says rows go to the owning machine's History.

Unaddressed findings

None.

Review coverage

• Both reviewers read every changed file except site/docs/index.html. That file was excluded as generated output from docs/guide.md, and npm run docs:check --prefix site passed.
• The fix commit d7cd2f7 came after the review. The reviewers did not read its new console/README.md lines or the reworded strings in src/console/inbox.html, docs/guide.md, site/index.html and the two test files.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

This adds static help text and one CSS rule. Reverting removes them, and no data or behaviour depends on them.

Blast Radius: cosmetic

The Done and Resolved sections each gain one paragraph, which pushes their rows down a little. While a Command is live, Overview does not show either section.

Closes #2218

Built with claude 2.1.314 · opus · default effort