Skip to content

Show Command kinds in compact Done rows - #2221

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-2216
Nov 14, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-2216

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Done headers identify the represented Command without opening Details or hovering. Local and received Fleet rows use human-facing names; stored Run displays as Ticket run, and Custom processes retain their process name. Parent/child grouping stays intact.

 ended  acme/widgets#42  Keep completed work easy to identify  merged
+       Ticket run / Spec run / Triage run / Process nightly-maintenance

The label and outcome remain readable on phones, without JavaScript and across Themes. Other Inbox sections retain their compact layout. Updates include the Console row description and public site explanations.

Closes #2216

Evidence

Execution evidence

  • Before: CARGO_BUILD_JOBS=2 cargo test --test console done_headers_identify_command_kinds_locally_and_across_fleet failed with Ticket run missing.
    After: the same command passed: 1 passed; 0 failed.
  • Before: node --test --test-name-pattern='Done headers keep' console/tests/inbox.test.cjs failed while waiting for .command-kind (Timeout 5000ms exceeded).
    After: the browser regression passed at 1440×900 and 390×844, JavaScript enabled/disabled, all six built-in Theme families in light/dark, live refresh and reload. It checks kind, outcome, issue link/number, age and overflow, including a long Custom process name and Ticket progress.
  • Both reviewers' exact 900px/1000px overlap discriminators failed before the review fix. The retained Ready regression failed with 1000: PR checks must not overlap Command kind or Ticket progress, then passed after limiting the extra label to Done. Coverage includes 1440, 1000, 900, 768 and 390px, with/without Ticket progress.
  • Focused Done, Ready and existing compact-folder regressions: 3 passed; 0 failed.
  • Final CARGO_BUILD_JOBS=2 /usr/bin/time -p scripts/affected-tests main: site PASS (58.13s), locked build PASS (10.86s), Console browser PASS (240 tests, 159.46s). The full Rust fallback cargo test stopped on the existing Plan usage test described below (1009.93s, compilation included; overall selector 1238.50s).
  • Local environment diagnosis: plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses removes its fake agy, then finds the real /home/jstephens/.local/bin/agy on inherited PATH. Its installed == false assertion therefore saw Bool(true). The exact case passed with the host tool directory excluded: env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin CARGO_BUILD_JOBS=2 cargo test --test plan_usage plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses -- --exact → 1 passed; 0 failed.
  • All CI checks passed, including all four Rust partitions and their coverage gate, on exact head 77774da46e08af15aa73e2dfd560a5d04b156f99. The full local suite was not repeated after successful CI, following repository validation policy.

Test seams

  • Console HTTP: retained Command records rendered as local and received Fleet Inbox headers.
  • Browser: rendered Done headers and existing compact Inbox/Ready headers, across viewports, Themes, JavaScript settings and live updates.

Visual evidence

Paired fixture captures were taken at the same viewports and Done state. Publishing via the secret-Gist workflow in thirdshift-pr failed: HTTP 404 ... This API operation needs the "gist" scope. No hosted image URLs are available with this session's credential. Exact retained capture paths:

Viewport Before After
1440×900 /tmp/before-desktop.0Dfvz2.png /tmp/after-desktop.2C6ANP.png
390×844 /tmp/before-mobile.HaOSBC.png /tmp/after-mobile.rLW3bB.png

Before, the rows show ended without an explicit kind. After, each header shows its kind and preserves the outcome on phones.

Review

Independent Standards and Spec reviews used git diff refs/remotes/origin/main...HEAD, pinned to cf24a5c7b1ad57b460987344999dd9e6b171a861.

  • Standards: 1 actionable finding, addressed (tablet badge overlap); no hard standards violations or actionable smells.
  • Spec: 1 actionable finding, addressed (the same tablet overlap).
  • Both reviewers read all eight changed files; no changed file was left unread and no generated output was excluded.
  • Reports: .thirdshift-review-izpA7W/standards.md, .thirdshift-review-izpA7W/spec.md, .thirdshift-review-izpA7W/summary.json (Session artifacts).

Unaddressed findings

Standards

None. No findings were skipped or declined.

Spec

None. No findings were skipped or declined.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Presentation only; no record migration.

Blast Radius: Console

Shared header rendering and responsive layout, with Done labels scoped to the Done section.

Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit ad94165 into main Nov 14, 2026
28 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2216 branch November 14, 2026 14:25
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it clear what kind of runs these were in this done runs view at /?section=done

1 participant