Repository navigation
Show Command kinds in compact Done rows - #2221
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Done headers identify the represented Command without opening Details or hovering. Local and received Fleet rows use human-facing names; stored
Rundisplays asTicket run, and Custom processes retain their process name. Parent/child grouping stays intact.ended acme/widgets#42 Keep completed work easy to identify merged + Ticket run / Spec run / Triage run / Process nightly-maintenanceThe label and outcome remain readable on phones, without JavaScript and across Themes. Other Inbox sections retain their compact layout. Updates include the Console row description and public site explanations.
Closes #2216
Evidence
Execution evidence
CARGO_BUILD_JOBS=2 cargo test --test console done_headers_identify_command_kinds_locally_and_across_fleetfailed withTicket run missing.After: the same command passed:
1 passed; 0 failed.node --test --test-name-pattern='Done headers keep' console/tests/inbox.test.cjsfailed while waiting for.command-kind(Timeout 5000ms exceeded).After: the browser regression passed at 1440×900 and 390×844, JavaScript enabled/disabled, all six built-in Theme families in light/dark, live refresh and reload. It checks kind, outcome, issue link/number, age and overflow, including a long Custom process name and Ticket progress.
1000: PR checks must not overlap Command kind or Ticket progress, then passed after limiting the extra label to Done. Coverage includes 1440, 1000, 900, 768 and 390px, with/without Ticket progress.3 passed; 0 failed.CARGO_BUILD_JOBS=2 /usr/bin/time -p scripts/affected-tests main: site PASS (58.13s), locked build PASS (10.86s), Console browser PASS (240 tests, 159.46s). The full Rust fallbackcargo teststopped on the existing Plan usage test described below (1009.93s, compilation included; overall selector 1238.50s).plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnessesremoves its fakeagy, then finds the real/home/jstephens/.local/bin/agyon inherited PATH. Itsinstalled == falseassertion therefore sawBool(true). The exact case passed with the host tool directory excluded:env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin CARGO_BUILD_JOBS=2 cargo test --test plan_usage plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses -- --exact→1 passed; 0 failed.77774da46e08af15aa73e2dfd560a5d04b156f99. The full local suite was not repeated after successful CI, following repository validation policy.Test seams
Visual evidence
Paired fixture captures were taken at the same viewports and Done state. Publishing via the secret-Gist workflow in
thirdshift-prfailed:HTTP 404 ... This API operation needs the "gist" scope. No hosted image URLs are available with this session's credential. Exact retained capture paths:/tmp/before-desktop.0Dfvz2.png/tmp/after-desktop.2C6ANP.png/tmp/before-mobile.HaOSBC.png/tmp/after-mobile.rLW3bB.pngBefore, the rows show
endedwithout an explicit kind. After, each header shows its kind and preserves the outcome on phones.Review
Independent Standards and Spec reviews used
git diff refs/remotes/origin/main...HEAD, pinned tocf24a5c7b1ad57b460987344999dd9e6b171a861..thirdshift-review-izpA7W/standards.md,.thirdshift-review-izpA7W/spec.md,.thirdshift-review-izpA7W/summary.json(Session artifacts).Unaddressed findings
Standards
None. No findings were skipped or declined.
Spec
None. No findings were skipped or declined.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Presentation only; no record migration.
Blast Radius: Console
Shared header rendering and responsive layout, with Done labels scoped to the Done section.
Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh