Skip to content

Fold skipped Pass messages while Commands are running - #2214

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-2211
Nov 14, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-2211

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Retained skipped Pass reasons now start folded while Commands are running. Native controls preserve keyboard and JavaScript-disabled access; live updates keep the reader's toggle state. Long reasons wrap on phones.

 Overview with a live Command
   Inbox groups
-  Individual idle Pass messages
+  Last recorded skipped Passes (closed)
+    Full reasons and links when opened

Closes #2211

Evidence

Execution evidence

  • Before: node --test --test-name-pattern='skipped Passes stay folded during live Commands' console/tests/inbox.test.cjs

    not ok 1 - skipped Passes stay folded during live Commands and preserve toggles across updates
    locator.waitFor: Timeout 5000ms exceeded.
    waiting for getByRole('complementary', { name: 'Idle Passes' }).locator('p').first() to be hidden
    14 × locator resolved to visible <p>Architect run idle on acme/widgets: at the Comman…</p>
    # pass 0
    # fail 1
    

    After: the same command:

    ok 1 - skipped Passes stay folded during live Commands and preserve toggles across updates
    # pass 1
    # fail 0
    
  • Final local selection: NEXTEST_TEST_THREADS=3 scripts/affected-tests main passed site checks (69/69), cargo build --locked, and Console browser checks (215/215). Nextest was unavailable, so the runner used cargo test; it stopped at plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses (tests/plan_usage.rs:322, installed true versus expected false). This unrelated fixture removes its fake agy but inherits the host PATH, which contains /home/jstephens/.local/bin/agy.

  • The exact test reproduced that failure alone. Excluding the host installation passes it:

    env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin cargo test --test plan_usage plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses -- --exact
    test plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses ... ok
    test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 8 filtered out
    
  • CI is green for this exact head (d72ff9e304e392e653da6d2fe4ae1ed66a94fbdc): console-test, site-test, all four rust-x86 / run shards, rust-x86 / complete, and test. Reused that successful full-suite result rather than repeating the full local run.

  • Repair validation at 66172947: env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin RUST_TEST_THREADS=3 NEXTEST_TEST_THREADS=3 scripts/affected-tests main passed the site checks (69/69), locked build, and Console browser checks (240/240). After clearing package artifacts reused by the baseline checkout, the full Rust suite passed separately with env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin RUST_TEST_THREADS=3 /usr/bin/time -p cargo test --no-fail-fast (exit 0; real 2490.50, compilation included). The original CI-failing test passed in that clean run. The focused asset tests also passed (3/3). No repository content changed.

Visual evidence

Captured the real compiled Console with synthetic records, one live Command and the same initial Overview state, at 1440×900 desktop and 390×844 phone. Inspected both Before/After pairs; the reasons become one collapsed summary.

Viewport Before capture After capture
Desktop, 1440×900 /tmp/before-desktop.2Uqxjy.png /tmp/after-desktop.r3sNBk.png
Phone, 390×844 /tmp/before-mobile.0n5OOO.png /tmp/after-mobile.cqYq90.png

Publishing these captures to the secret Gist required by thirdshift-pr is blocked: gh gist create returned HTTP 404: Not Found and This API operation needs the "gist" scope. The configured account has read:org, repo and workflow scopes. Captures remain at the exact local paths above; no public image URLs are available.

CI notes

  • CI run 43597992022 failed only at github::mergeability_changes_wake_ready_rows_independently_of_ci (tests/console/github.rs:214): an existing startup race lets the fixture's PR link satisfy wait_for before the first GitHub refresh, so concurrent status can return empty cached facts while the Console holds the refresh lock (github_last_answered_at: null in the failure). The test and refresh code are identical to main at 5372181f; the exact test passed on this branch and in 21/21 unmodified-main runs. The failing fixture has no active Commands or retained Passes, so this branch's disclosure is not rendered. rust-x86 / complete and test propagate this shard failure.

Test seams

  • The served Console Inbox at /?section=overview, using recorded Activity logs and a live Command: initial folding, native keyboard controls with and without JavaScript, live message updates and toggle retention, reload reset, links and responsive layout.

Review coverage

Independent thirdshift-code-review reviews against refs/remotes/origin/main (f00bb1014c4e66bb9a33935ea4d777f60d207ffe): Standards 0, Spec 0 actionable findings. Both axes read every changed file: console/README.md, console/tests/inbox.test.cjs, site/how-it-works/index.html, src/console/assets/console.css, and src/console/inbox.html.

Unread changed files: none. Generated-output exclusions: none. Reports and each axis's final supporting files-read list are saved in .thirdshift-review-5TsyQU/standards.md and spec.md, with summary.json containing {"standards":0,"spec":0}.

Unaddressed findings

Standards

None.

Spec

None.

Security

None. The change wraps the existing escaped linkify output in a native <details> element; it adds no new input, sink or trust boundary.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the template and wrapping rule to restore the prior display.

Blast Radius: Console

Changes presentation of retained skipped Pass messages; scheduling and Command execution are unaffected.

Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit cf505b7 into main Nov 14, 2026
24 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2211 branch November 14, 2026 14:47
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make all of these small lines folded underneath a fold open and closed-er element to clean up the layout of the page on on load at /?section=overview

1 participant