Repository navigation
Fold skipped Pass messages while Commands are running - #2214
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retained skipped Pass reasons now start folded while Commands are running. Native controls preserve keyboard and JavaScript-disabled access; live updates keep the reader's toggle state. Long reasons wrap on phones.
Closes #2211
Evidence
Execution evidence
Before:
node --test --test-name-pattern='skipped Passes stay folded during live Commands' console/tests/inbox.test.cjsAfter: the same command:
Final local selection:
NEXTEST_TEST_THREADS=3 scripts/affected-tests mainpassed site checks (69/69),cargo build --locked, and Console browser checks (215/215). Nextest was unavailable, so the runner usedcargo test; it stopped atplan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses(tests/plan_usage.rs:322, installedtrueversus expectedfalse). This unrelated fixture removes its fakeagybut inherits the host PATH, which contains/home/jstephens/.local/bin/agy.The exact test reproduced that failure alone. Excluding the host installation passes it:
env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin cargo test --test plan_usage plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses -- --exactCI is green for this exact head (
d72ff9e304e392e653da6d2fe4ae1ed66a94fbdc):console-test,site-test, all fourrust-x86 / runshards,rust-x86 / complete, andtest. Reused that successful full-suite result rather than repeating the full local run.Repair validation at
66172947:env PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin RUST_TEST_THREADS=3 NEXTEST_TEST_THREADS=3 scripts/affected-tests mainpassed the site checks (69/69), locked build, and Console browser checks (240/240). After clearing package artifacts reused by the baseline checkout, the full Rust suite passed separately withenv PATH=/home/jstephens/.cargo/bin:/usr/bin:/bin RUST_TEST_THREADS=3 /usr/bin/time -p cargo test --no-fail-fast(exit 0;real 2490.50, compilation included). The original CI-failing test passed in that clean run. The focused asset tests also passed (3/3). No repository content changed.Visual evidence
Captured the real compiled Console with synthetic records, one live Command and the same initial Overview state, at 1440×900 desktop and 390×844 phone. Inspected both Before/After pairs; the reasons become one collapsed summary.
/tmp/before-desktop.2Uqxjy.png/tmp/after-desktop.r3sNBk.png/tmp/before-mobile.0n5OOO.png/tmp/after-mobile.cqYq90.pngPublishing these captures to the secret Gist required by
thirdshift-pris blocked:gh gist createreturnedHTTP 404: Not FoundandThis API operation needs the "gist" scope.The configured account hasread:org,repoandworkflowscopes. Captures remain at the exact local paths above; no public image URLs are available.CI notes
github::mergeability_changes_wake_ready_rows_independently_of_ci(tests/console/github.rs:214): an existing startup race lets the fixture's PR link satisfywait_forbefore the first GitHub refresh, so concurrentstatuscan return empty cached facts while the Console holds the refresh lock (github_last_answered_at: nullin the failure). The test and refresh code are identical to main at5372181f; the exact test passed on this branch and in 21/21 unmodified-main runs. The failing fixture has no active Commands or retained Passes, so this branch's disclosure is not rendered.rust-x86 / completeandtestpropagate this shard failure.Test seams
/?section=overview, using recorded Activity logs and a live Command: initial folding, native keyboard controls with and without JavaScript, live message updates and toggle retention, reload reset, links and responsive layout.Review coverage
Independent
thirdshift-code-reviewreviews againstrefs/remotes/origin/main(f00bb1014c4e66bb9a33935ea4d777f60d207ffe): Standards 0, Spec 0 actionable findings. Both axes read every changed file:console/README.md,console/tests/inbox.test.cjs,site/how-it-works/index.html,src/console/assets/console.css, andsrc/console/inbox.html.Unread changed files: none. Generated-output exclusions: none. Reports and each axis's final supporting files-read list are saved in
.thirdshift-review-5TsyQU/standards.mdandspec.md, withsummary.jsoncontaining{"standards":0,"spec":0}.Unaddressed findings
Standards
None.
Spec
None.
Security
None. The change wraps the existing escaped
linkifyoutput in a native<details>element; it adds no new input, sink or trust boundary.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the template and wrapping rule to restore the prior display.
Blast Radius: Console
Changes presentation of retained skipped Pass messages; scheduling and Command execution are unaffected.
Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh