Skip to content

Make the closed Inbox Start work panel compact - #2213

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-2209
Nov 14, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-2209

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Make the Inbox's closed Start work disclosure a compact single line, keeping the expanded form's spacing and feedback visible while closed. Cron jobs retains its existing spacing.

- Closed Start work with empty feedback: about 83–84px
+ Closed Start work with empty feedback: 46px, with a 44px summary hit area

Closes #2209.

Test seam: the rendered Console Inbox in Chromium, using native pointer/Enter/Space disclosure activation, visible focus, form geometry, and page overflow. Existing Start tests exercise pending, success, and failure feedback from Inbox rows while the form stays closed, plus confirmation and Cron jobs controls.

Evidence

Execution evidence

  • Before: node --test --test-name-pattern='closed Start work' console/tests/start.test.cjs failed all 24 Theme/viewport cases. Focus reported closed Start work height 83.796875px exceeds one line.
    After: the same command passed all 24 cases (25 tests including the parent), across all six Theme families in light/dark at 1440×900 and 390×844.
  • node --test console/tests/start.test.cjs: 39 tests passed, 0 failed.
  • scripts/affected-tests main: Console build passed; all 239 browser tests passed (118.10s). Its full cargo test stopped after 1033.42s, including compilation, on the unrelated local test plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses: tests/plan_usage.rs:322 expected installed == false, got true.
  • The exact focused reproduction, cargo test --test plan_usage plan_usage_shows_configured_routes_in_order_and_omits_api_key_and_unused_harnesses -- --exact, fails under the inherited host PATH and passes (1 test, 0 failures, 0.09s) when only /home/jstephens/.local/bin is excluded from that command's PATH. tests/plan_usage.rs:34 removes the fixture's fake agy, but tests/support/mod.rs:959 retains the host PATH, exposing the installed /home/jstephens/.local/bin/agy. No Plan usage code changed in this PR.
  • All CI checks passed for exact head 0d2224b61da4276d612206aa69f991b193a59038, including all four Rust partitions, Console browser tests and site tests. Successful CI covers the remaining Rust suites; the full suite was not repeated after CI passed.

Visual evidence

Matching Focus light captures were saved before source changes and inspected after the change. The closed panel measures 83.796875px before and 46px after at both viewports.

Viewport and state Before capture After capture
1440×900, closed with no feedback /tmp/before-desktop.NeIyiT.png /tmp/after-desktop.xmgPi7.png
390×844, closed with no feedback /tmp/before-mobile.BlEOBt.png /tmp/after-mobile.OTpgbV.png

Media publication limitation: the required secret Gist upload was attempted with gh gist create and failed with HTTP 404: This API operation needs the "gist" scope. The available token lacks that scope, so the captures remain at the exact session-host paths above instead of embedded Gist URLs. Copies are also retained beside the review reports in .thirdshift-review-Y3GPb2/visual-evidence/.

Review coverage

Independent Standards and Spec reviews used git diff refs/remotes/origin/main...HEAD, pinned to base f00bb1014c4e66bb9a33935ea4d777f60d207ffe. Standards: 0 actionable findings. Spec: 0 actionable findings. Both axes read all three changed files: console/tests/start.test.cjs, src/console/assets/console.css, and src/console/start_form.html. No generated files were excluded. No changed file remains unread by either axis. Reports and {"standards":0,"spec":0} are saved in .thirdshift-review-Y3GPb2/.

Unaddressed findings

Standards

None.

Spec

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

The template class and scoped spacing rules can be reverted together.

Blast Radius: Console

Inbox Start work spacing only; no start API or Theme token changes.

Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 5372181 into main Nov 14, 2026
28 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2209 branch November 14, 2026 12:57
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make this start work container more slim when folded closed

1 participant