Skip to content

Decide how a Run treats a check that also fails on the Base branch - #220

Merged
JacobStephens2 merged 1 commit into
mainfrom
103-grill
Oct 1, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
103-grill

Conversation

@JacobStephens2

Copy link
Copy Markdown
Owner

Summary

Docs only: the decision for #103, from a grilling session. The code comes later, through the Spec and Tickets.

 RepairLoop: CI red on head
+  compare failed checks with the Base branch commit head merged in (by name)
+  red on both → Inherited failure, no Repair
+    Base branch moved?        → merge it in, go round again
+    Base fix allowed?         → Merge run into the Base branch, wait, go round again
+    otherwise                 → Failed run: "CI red on <check>, which also fails on <base> at <sha>; fix <base> first"
   red on head only → CI-fix Repair (as today)
  • CONTEXT.md: adds Inherited failure and Base fix, mentions the Base fix in the User config entry, and rewords the example in Declined CI fix.
  • docs/adr/0008-inherited-failures-fail-the-run.md: the decisions, the options we rejected, and the accepted trade-off (a different failure in the same check hides behind the Base branch's red).

Evidence

  • Before: JacobStephens2/chart35#71 spent a Repair ($0.35, 51s) only to find that Verify also failed on main, then ended as a Declined CI fix.
    After (once implemented): two API calls detect the same thing, and the Run fails with fix main first, or a Base fix fixes main.

Merge Danger

Door: two-way

Glossary and ADR only; no behavior changes.

Blast Radius: none

🤖 Generated with Claude Code

Add Inherited failure and Base fix to the glossary, and record the
policy in ADR 0008: an Inherited failure fails the Run without a
Repair, unless a Base fix is allowed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JacobStephens2
JacobStephens2 merged commit 7b4b099 into main Oct 1, 2026
3 checks passed
@JacobStephens2
JacobStephens2 deleted the 103-grill branch October 1, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant