[JacobStephens2]

Summary

Escape now clears the selected Waterfall row after closing Peek, matching the Inbox.

Escape
  close help
  else close jump list
  else close Peek
  else clear selection (including the Waterfall)

Empty selection survives live updates and expansion controls. The tree retains a keyboard entry point; navigation or a click selects a row again.

Closes #2180

Evidence

Execution evidence

Seam under test: the real Console served by the built binary, exercised through browser clicks, keys, rendered rows and ARIA state using isolated Command records.

• Before: node --test --test-name-pattern='Escape closes Waterfall layers' console/tests/spans.test.cjs

  not ok 1 - Escape closes Waterfall layers then clears selection at desktop and 390 px
  second Escape clears the selected span
  1 !== 0
  # pass 0
  # fail 1
  

  After: the same command passes:

  ok 1 - Escape closes Waterfall layers then clears selection at desktop and 390 px
  # pass 1
  # fail 0
  

• node --test console/tests/spans.test.cjs console/tests/waterfall.test.cjs: 11/11 pass, including empty selection, keyboard entry/navigation, expansion controls, changed-data refresh and running renders at desktop and phone widths.
• node --test --test-name-pattern='every keyboard action preserves list nodes and Escape closes one layer at a time' console/tests/inbox.test.cjs: 1/1 pass.
• scripts/affected-tests main: PASS. Build passed; all 208 Console browser tests and all 4,525 Rust tests passed (201 skipped). The Rust check took 2,996.09 seconds including compilation; test execution took 2,774.251 seconds.
• CI for this commit: all checks green.

Visual evidence

Same flow in each pair: select a Session, press Escape to close Peek, then press Escape again. Fixture Commands only.

Desktop, 1440×900

Phone, 390×844

Merge Danger

Door: two-way

Revert the asset and test changes to restore the previous behavior.

Blast Radius: Console

Waterfall selection, focus and shared Escape handling. The existing Inbox Escape regression passes.

Review coverage

Standards: 0 actionable findings. Spec: 0 actionable findings. Both reviewers read all five changed files; no changed file was left unread. No generated-output exclusions.

Unaddressed findings

• Standards: None.
• Spec: None.
• Security: None.

Built with codex codex-cli 0.169.0 · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.