Skip to content

Add Copy to every top-level Inbox row - #2179

Merged
JacobStephens2 merged 5 commits into
mainfrom
issue-2174
Nov 14, 2026
Merged

JacobStephens2 merged 5 commits into
mainfrom
issue-2174

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Inbox / Overview and section folders
-  Needs you → Copy local context
+  Every top-level row → Copy rendered context, including Fleet ownership
+    section · machine · Command · repository · title · state · CI/conflict
+    absolute links · machine-qualified thirdshift show command

Mouse and keyboard Copy leave Command details in place. Clipboard failures keep a selected snapshot through live updates. The manual and site describe the expanded action.

Closes #2174

Evidence

Execution evidence

  • Before: node --test --test-name-pattern='Ready for review copies rendered context' console/tests/inbox.test.cjs
    failed at the visible Copy assertion: false !== true (0 passed, 1 failed).
    After: the same command passed: tests 1, pass 1, fail 0.
  • node --test --test-name-pattern='copies rendered context|Inbox Copy|fallback snapshot|Needs you copies|Needs you keeps selected context|Fleet Inbox polls' console/tests/inbox.test.cjs console/tests/fleet.test.cjs: 8 passed, 0 failed. Covers local and Fleet rows, all folders, absolute links, CI/conflict facts, keyboard activation, clipboard failures, live updates and phone layout.
  • npm run docs:check --prefix site, cargo fmt --check, and git diff --check: passed.
  • scripts/affected-tests main: passed. Site suite, all 209 Console browser tests, and the full Rust suite (4,525 passed, 0 failed; 201 ignored) passed. The selector used the cargo test fallback; its measured wall time was 1,316.25 s, including test compilation.
  • CI passed on 59a35821, including all Rust partitions, Console and site browser checks.

Test seams: rendered Inbox controls and clipboard output in the real Console browser; authenticated Fleet Inbox presentation and machine-qualified links.

Visual evidence

Overview, Ready for review row, 1440 × 900 desktop:

  • Before: /tmp/before-desktop.h3gUqG.png
  • After: /tmp/after-desktop.cmJtqp.png

Overview, Ready for review row, 390 × 844 phone:

  • Before: /tmp/before-mobile.2pFELx.png
  • After: /tmp/after-mobile.7O9Xnc.png

The captures use sample records and matching viewport/state; the phone view is scrolled to the Ready for review row. Secret Gist publication was attempted but GitHub returned HTTP 404 and This API operation needs the "gist" scope. The available account token has read:org, repo, and workflow scopes, so the PNGs remain at the exact local paths above and cannot be embedded from a raw Gist URL.

Review

Independent Standards and Spec reviews against refs/remotes/origin/main (960f0265): 0 actionable findings on each axis. Both reviewers read all 11 changed files, including the generated manual hunk; no exclusions or unread changed files.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert to restore the previous Copy availability; no stored data or GitHub state changes.

Blast Radius: Inbox

Shared row controls and clipboard text; History and Security retain their existing controls.

Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 0b4772b into main Nov 14, 2026
24 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2174 branch November 14, 2026 02:28
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add copy button to inbox rows

1 participant