Repository navigation
Add Copy to every top-level Inbox row - #2179
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mouse and keyboard Copy leave Command details in place. Clipboard failures keep a selected snapshot through live updates. The manual and site describe the expanded action.
Closes #2174
Evidence
Execution evidence
node --test --test-name-pattern='Ready for review copies rendered context' console/tests/inbox.test.cjsfailed at the visible Copy assertion:
false !== true(0 passed, 1 failed).After: the same command passed:
tests 1,pass 1,fail 0.node --test --test-name-pattern='copies rendered context|Inbox Copy|fallback snapshot|Needs you copies|Needs you keeps selected context|Fleet Inbox polls' console/tests/inbox.test.cjs console/tests/fleet.test.cjs: 8 passed, 0 failed. Covers local and Fleet rows, all folders, absolute links, CI/conflict facts, keyboard activation, clipboard failures, live updates and phone layout.npm run docs:check --prefix site,cargo fmt --check, andgit diff --check: passed.scripts/affected-tests main: passed. Site suite, all 209 Console browser tests, and the full Rust suite (4,525 passed, 0 failed; 201 ignored) passed. The selector used thecargo testfallback; its measured wall time was 1,316.25 s, including test compilation.59a35821, including all Rust partitions, Console and site browser checks.Test seams: rendered Inbox controls and clipboard output in the real Console browser; authenticated Fleet Inbox presentation and machine-qualified links.
Visual evidence
Overview, Ready for review row, 1440 × 900 desktop:
/tmp/before-desktop.h3gUqG.png/tmp/after-desktop.cmJtqp.pngOverview, Ready for review row, 390 × 844 phone:
/tmp/before-mobile.2pFELx.png/tmp/after-mobile.7O9Xnc.pngThe captures use sample records and matching viewport/state; the phone view is scrolled to the Ready for review row. Secret Gist publication was attempted but GitHub returned
HTTP 404andThis API operation needs the "gist" scope. The available account token hasread:org,repo, andworkflowscopes, so the PNGs remain at the exact local paths above and cannot be embedded from a raw Gist URL.Review
Independent Standards and Spec reviews against
refs/remotes/origin/main(960f0265): 0 actionable findings on each axis. Both reviewers read all 11 changed files, including the generated manual hunk; no exclusions or unread changed files.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert to restore the previous Copy availability; no stored data or GitHub state changes.
Blast Radius: Inbox
Shared row controls and clipboard text; History and Security retain their existing controls.
Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh