Repository navigation
Back off unchanged GitHub waits and reuse PR observations - #2142
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies to CI, PR mergeability and existing Base fix waits. The existing test override scales the schedule. The manual describes the cadence.
Closes #2138
Evidence
Execution evidence
cargo test --test ci polling::thirty_minutes -- --nocapturefailed:47 CI polls over 30 simulated minutes.After: the same command passed (
1 passed; 0 failed), enforcing at most 40 polls and a reported green result.cargo test --test ci polling::a_pending -- --nocapturefailed:PR observations between pending CI reads,left: 2,right: 1.After: the same command passed (
1 passed; 0 failed).head move was observed, but the next CI poll waited 1524101us; expected the 250ms shortest step. After retaining the test and including the observed head in backoff,cargo test --test ci polling::an_observed_head_move_resets_the_pending_ci_pause -- --exact --nocapturepassed (1 passed; 0 failed). Its final timing uses a 1s shortest step, 6s maximum and 4s assertion to leave several seconds for subprocess work, addressing Standards' deadline finding.1 passed; 0 failed, 39.35s).cargo fmt --checkpassed.CARGO_BUILD_JOBS=2 scripts/affected-tests mainselected site checks and the full Rust suite: site checks passed in 107.10s; the duplicate local Rust run was stopped without reported failures after CI completed successfully on the exact same head, reusing that coverage perdocs/testing.md.9a28b50fbd2d3b8aea7ead73d2a74c1b84c9d3c8, including all four Rust partitions, their coverage gate, formatting/typechecking and site/Console checks.Visual evidence
Manual waiting cadence, desktop 1440×900:
Manual waiting cadence, mobile 390×844:
Test seams
Review coverage
Reviewed against
refs/remotes/origin/main, pinned at943166dea1ef448c2a50e345bedc6b3ef6257bd4. Standards raised one finding and Spec raised one; both were addressed.Both axes read all eleven changed source/test/documentation files.
site/docs/index.htmlwas intentionally excluded from source reading by both axes:docs/guide.mdandsite/generate-docs.mjswere reviewed,npm run docs:check --prefix sitepassed, and the rendered desktop/mobile captures were inspected. No other changed files were left unread.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Commands
Unchanged GitHub waits can take up to sixty seconds to notice completion. Stop and interruption keep the existing 100ms sleep checks.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh