Repository navigation
Fold Fleet schedule repositories closed on every load - #2141
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2121
Test seam: the rendered Console
/cronjobs?fleet=truepage, through browser navigation, pointer and keyboard interaction, at desktop and phone widths with JavaScript enabled and disabled. Existing local Cron jobs browser checks also guard that page's behavior.Each repository and Other now uses a native disclosure, leaving Machines status visible. The guide and site explain default folding and expansion lasting only for the current visit.
Evidence
Execution evidence
node --test console/tests/cronjobs.test.cjs— 14 tests, 9 passed, 5 failed. All four Fleet variants failed withlocator.waitFor: Timeout 5000ms exceeded, waiting for.cron-repository's firsth3to be hidden; it remained visible.After:
node --test console/tests/cronjobs.test.cjs— 14 passed, 0 failed. Covers initial folding, independent pointer/Enter/Space toggles, reload, duplicate commands, escaped text, visible machine status and horizontal command scrolling at 1440×900 and 390×844, with JavaScript enabled and disabled.cargo build --lockedpassed.RUST_TEST_THREADS=3 scripts/affected-tests mainpassed: site suite (69 tests), locked build, Console suite (205 tests), and the full Rust suite. The runner measuredcargo testat 2169.97 seconds, including warm compilation. This followsdocs/testing.md's advice to reduce concurrency for load-sensitive failures.scripts/affected-tests mainrun passed the site and Console suites, then stopped on the unrelated existingdismissed_live_command_returns_when_it_dies_fails_or_ends_readytest withrow is in Working, not Needs you or Ready for review.cargo test --test dismiss dismissed_live_command_returns_when_it_dies_fails_or_ends_ready -- --exactimmediately passed (1 passed, 0 failed), and the same test passed in the full lower-concurrency retry. No source changes were needed for this failure.Visual evidence
Matching full-page captures were taken from the fixture Console at the initial-load state, using the requested viewports, and inspected locally:
/tmp/before-desktop.lkqn7q.png/tmp/after-desktop.H6NZEm.png/tmp/before-mobile.jGXSxW.png/tmp/after-mobile.HCOM0K.pngPublishing the required secret Gist was attempted with
gh gist create --desc 'PR visual evidence for thirdshift #2121' /tmp/issue-2121-pr.md; GitHub returnedHTTP 404: Not FoundandThis API operation needs the "gist" scope.This headless session's authenticated account cannot upload the captures, so remotely embedded images are unavailable.Unaddressed findings
Standards
None. The independent Standards review raised 0 findings.
Spec
None. The independent Spec review raised 0 findings.
Security
None. The guidance-mode review of the Fleet schedules disclosure, the fields rendered into it, and the shared fold script found no unaddressed introduced findings.
Security review outcome
No unaddressed introduced findings.
Review coverage
Both axes inspected all eight changed files, including the generated manual paragraph. No changed files were left unread and no generated-output exclusions were used. Reports and final files-read lists are stored in
.thirdshift-review-vxIC9w/standards.mdand.thirdshift-review-vxIC9w/spec.md, withsummary.jsonrecording{"standards":0,"spec":0}.Merge Danger
Door: two-way
Revert the template, one CSS rule and accompanying documentation/tests to restore expanded groups. No data migration.
Blast Radius: Console
Presentation of repository groups on Fleet schedules; expanded commands retain their scrolling blocks.
Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh