Skip to content

Fold Fleet schedule repositories closed on every load - #2141

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-2121
Nov 12, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-2121

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fleet schedules
├── Machines status (visible)
└── Repository / Other (closed on every load)
    └── Machines and schedules (independent native disclosures)

Closes #2121

Test seam: the rendered Console /cronjobs?fleet=true page, through browser navigation, pointer and keyboard interaction, at desktop and phone widths with JavaScript enabled and disabled. Existing local Cron jobs browser checks also guard that page's behavior.

Each repository and Other now uses a native disclosure, leaving Machines status visible. The guide and site explain default folding and expansion lasting only for the current visit.

Evidence

Execution evidence

  • Before: node --test console/tests/cronjobs.test.cjs — 14 tests, 9 passed, 5 failed. All four Fleet variants failed with locator.waitFor: Timeout 5000ms exceeded, waiting for .cron-repository's first h3 to be hidden; it remained visible.
    After: node --test console/tests/cronjobs.test.cjs — 14 passed, 0 failed. Covers initial folding, independent pointer/Enter/Space toggles, reload, duplicate commands, escaped text, visible machine status and horizontal command scrolling at 1440×900 and 390×844, with JavaScript enabled and disabled.
  • cargo build --locked passed.
  • Final validation: RUST_TEST_THREADS=3 scripts/affected-tests main passed: site suite (69 tests), locked build, Console suite (205 tests), and the full Rust suite. The runner measured cargo test at 2169.97 seconds, including warm compilation. This follows docs/testing.md's advice to reduce concurrency for load-sensitive failures.
  • The first scripts/affected-tests main run passed the site and Console suites, then stopped on the unrelated existing dismissed_live_command_returns_when_it_dies_fails_or_ends_ready test with row is in Working, not Needs you or Ready for review. cargo test --test dismiss dismissed_live_command_returns_when_it_dies_fails_or_ends_ready -- --exact immediately passed (1 passed, 0 failed), and the same test passed in the full lower-concurrency retry. No source changes were needed for this failure.

Visual evidence

Matching full-page captures were taken from the fixture Console at the initial-load state, using the requested viewports, and inspected locally:

Viewport Before After
1440×900 /tmp/before-desktop.lkqn7q.png /tmp/after-desktop.H6NZEm.png
390×844 /tmp/before-mobile.jGXSxW.png /tmp/after-mobile.HCOM0K.png

Publishing the required secret Gist was attempted with gh gist create --desc 'PR visual evidence for thirdshift #2121' /tmp/issue-2121-pr.md; GitHub returned HTTP 404: Not Found and This API operation needs the "gist" scope. This headless session's authenticated account cannot upload the captures, so remotely embedded images are unavailable.

Unaddressed findings

Standards

None. The independent Standards review raised 0 findings.

Spec

None. The independent Spec review raised 0 findings.

Security

None. The guidance-mode review of the Fleet schedules disclosure, the fields rendered into it, and the shared fold script found no unaddressed introduced findings.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both axes inspected all eight changed files, including the generated manual paragraph. No changed files were left unread and no generated-output exclusions were used. Reports and final files-read lists are stored in .thirdshift-review-vxIC9w/standards.md and .thirdshift-review-vxIC9w/spec.md, with summary.json recording {"standards":0,"spec":0}.

Merge Danger

Door: two-way

Revert the template, one CSS rule and accompanying documentation/tests to restore expanded groups. No data migration.

Blast Radius: Console

Presentation of repository groups on Fleet schedules; expanded commands retain their scrolling blocks.

Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit a1a21ee into main Nov 12, 2026
24 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-2121 branch November 12, 2026 19:26
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make cronjobs?fleet=true console web ui page load with each repo section folded closed, and let the user unfold each section

1 participant