Repository navigation
Fix unreadable OS accounts missing from Fleet metrics - #2136
Merged
Merged
Conversation
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fleet metrics now retain each machine's unreadable OS accounts through local and live reads, cached snapshots and pushed reports, and name them in JSON, text and the Console's Machines list.
Summarypreviously discarded the field during deserialization. The shared summary now retains it, and the Fleet merge assigns it to its owning machine. The manual and three hand-written site pages describe the diagnostic.Closes #2112
Evidence
Execution evidence
cargo test --test console fleet_metrics_keep_unreadable_accounts_per_machine -- --nocapturefailed withleft: Null,right: Array [String("thirdshift-missing-local")];0 passed; 1 failed.After: the same command passed:
1 passed; 0 failed. It checks local, live-remote and cached accounts in JSON/text/HTML and machine selection.cargo test --test console metrics -- --nocapture: 25 passed, covering push/report propagation and older peer/snapshot defaults.npm run docs:check --prefix site: passed.scripts/affected-tests main: passed — 69 site tests, 205 Console browser tests and 4,469 Rust tests (199 skipped). The selector measuredcargo nextest runat 3,839.84 seconds including compilation (3m 11s); test execution took 3,646.682 seconds. Console browser fixtures used a fixed copy of the final binary.7e4bce59.Seams under test: public
metrics --fleet/--machineJSON and text, the Console's/metricsMachines list, andmetrics --pushthrough the holder-bound report endpoint. Compatibility checks cover old peer responses and saved summaries withoutunavailable_accounts.Visual evidence
Fleet Machines list, with the same local and reported-machine fixtures. Both viewports have no horizontal page overflow.
Desktop · 1440×900
Mobile · 390×844
Review coverage
Independent Standards and Spec reviews use
refs/remotes/origin/main(d6e961c4). Standards: 0 findings. Spec: 1 finding, fixed by putting the machine's status and unreadable accounts on the same text line and retaining its regression. Both reviewers read every changed file, including the generated manual hunk; no generated-output exclusions and no unread changed files.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reversible presentation and additive summary fields; older peers and saved summaries remain readable.
Blast Radius: Metrics
Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh