Repository navigation
Treat blank Triage questionnaires as absent - #2135
Merged
Merged
Conversation
Preserve blank-questionnaire normalization and needs-info-only guidance while adopting repository categories in both Triage modes and category correction. Regenerate prompts and the manual from merged sources. Validation: prompt generation, formatting, site and Console browser suites passed. The affected-test run stopped at an intermittent setup cleanup assertion; its isolated rerun, the complete setup suite and all remaining Rust targets passed without code changes.
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize before state validation so empty questionnaires need no correction turn. Add a
ready-for-agentexample withoutquestionnaireand regenerate the prompts page. As #2052 explicitly requires,ready-for-humannow omits questionnaires too; its issue body carries the decision or operator action. Update the prompts, questionnaire skill and user documentation to agree.Closes #2052
Evidence
Execution evidence
cargo test --test triage_run blank_questionnaires_are_absent_without_a_correction -- --exact1 passed; 0 failed. It covers null, empty strings, ASCII/Unicode whitespace and per-issue state overrides, and asserts exactly one Harness session.cargo test --test triage_run --test triage_correction --test triage_issue --test triage_spec_regressions: 57 passed, 8 fixture entry points ignored. Includes rejection of non-empty questionnaires outsideneeds-info, rejection of blankneeds-infoquestions, and publication/notification checks.UPDATE_PROMPTS=1 cargo test prompts_page: 14 passed; generated outputs updated.npm run docs:check --prefix siteandcargo fmt --checkpassed.RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main: 69 site tests passed (52.16 s), 1,837 Rust unit tests passed, and 326 Console integration tests passed, along with the completed CLI suites. The selector chosecargo testbecause nextest is unavailable. The local broad run was interrupted after 1,023.35 s, including incremental compilation, when experiment fixtures inherited interactive terminal stdin and waited for input; this is not a local full-suite pass.cargo test --test experiments <case> -- --exact --nocapture < /dev/null. No source change was needed. The waiting-line case failed alone withthe agent never startedafter 120.38 s with terminal stdin, then passed in 10.84 s with stdin closed.8be3a86cfa898ac48e34c3f5d891e2c0c343f86b, including all four Rust partitions and their coverage gate, site and Console browser tests, release smoke, and Linux artifact builds. Reused that exact-head full Rust result instead of starting another broad local run.Passing isolated experiment cases
Visual evidence
Paired Chromium captures show the expanded Triage skill's recommendation examples at identical positions and viewports. Both rendered examples parse as JSON; the new
ready-for-agentexample has no questionnaire. The captures were visually inspected./tmp/before-desktop.y6F3Tx.png/tmp/after-desktop.FWnfrH.png/tmp/before-mobile.zUHS6y.png/tmp/after-mobile.LNoS7p.pngCapture publication is unavailable:
gh gist createreturned HTTP 404 and explicitly reported that the GitHub token needs thegistscope. No raw Gist URLs could be produced; the exact capture paths remain in this Session. No evidence media was added to the repository branch.Test seams
thirdshift triageCLI with a fake Harness and GitHub: recommendation stdout, issue publication, Run notification and the number of Harness sessions.Review coverage
Independent
thirdshift-code-reviewStandards and Spec reviews usedgit diff refs/remotes/origin/main...HEAD, fixed atd6e961c4c517e0858b29a827028c3c2191c63140. Each reviewed all 18 changed files, including generated output. Standards: 0 findings. Spec: 0 findings. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the parser, guidance and generated documentation together; no stored-data migration.
Blast Radius: Triage
Questionnaires belong only to
needs-info, including when a per-issue state overrides the overall recommendation.ready-for-humanrecommendations with non-empty questionnaires are now rejected, as required by #2052.Built with codex codex-cli 0.167.2 · gpt-6.1-sol · xhigh
CI notes
390px remote review-explicit: visible PR targetassertion atconsole/tests/working-targets.test.cjs:83; the test, Console/rendering/logging code, dependencies and CI workflow are unchanged in the branch diff against main, and localcargo build --locked,node --test console/tests/working-targets.test.cjs(1 passed), andnpm test --prefix console(205 passed, 0 failed/skipped; 133.24 s) all passed on unchanged headdd0fc21a; no unrelated code changes.