Repository navigation
Say why aws-lc and axoupdater's image stack stay - #213
Merged
Merged
Conversation
axoupdater needs axoasset's remote feature, which always pulls in image and turns on reqwest's default-tls (rustls with aws-lc). No flag drops either, and asking reqwest for ring would build ring alongside aws-lc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No flag can drop aws-lc or the image stack. Both are forced by axoupdater's required
axoasset/remote, so this PR only records why, inCargo.toml, and the follow-up is on #174 (comment).Features unify, so switching our own reqwest to
rustls-no-providerplus rustls'sringstill builds aws-lc (checked withcargo tree -i aws-lc-sys), and would build ring on top of it. So our reqwest is left as it was.The first acceptance criterion is not met:
cargo tree -i aws-lc-sysstill finds it. Every way to meet it is out of scope under #174: forking axoasset with[patch], going back to axoupdater 0.9 / axoasset 1.x, or replacing axoupdater. The #174 comment lays out these options. The maintainer should decide whether that's enough to close #203.Evidence
Cold
cargo test --no-run(empty target dir), and then a warm fullcargo test, against the #174 baseline. There's no dependency change, so the difference comes from machine load, not from this PR. Other Runs were active, and load was about 3× the baseline's, so these times are not idle-machine numbers.cargo test --no-runwallcargo test --no-runuser + syscargo testwallcargo testuser + systest result: ok, 0 failed.cargo tree -i aws-lc-sys: still present, via our reqwestrustlsfeature and via axoassetdefault-tls. With our side switched torustls-no-provider, it's still present via axoasset.Cargo.lockare untouched.Merge Danger
Door: two-way
A comment only.
Blast Radius: none
Cargo.lockand the built binary are unchanged.Unaddressed findings
Standards
ringfeature") were fixed in 8df4211.Spec
cargo tree -i aws-lc-sys(andaws-lc-rs) finds nothing": not met. The only fixes are forking, downgrading or replacing axoupdater, and Make the test suite faster #174 puts all of those out of scope. Explained on Make the test suite faster #174.thirdshift updatecheck against the real release endpoint still works": skipped. The dependency graph andCargo.lockare unchanged, so the updater is byte-for-byte the same. A dev build has no install receipt and refuses before any network call. Running the installed copy would replace the maintainer's binary.Closes #203
🤖 Generated with Claude Code