Repository navigation
Only escalate Slow runs far past their Usual range - #2074
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry Slow child markers into compact Spec and Pass summaries, including on phones. Keep Silent precedence and the existing Dismissal rules. Update the glossary, manual and site descriptions.
Closes #1465
Evidence
Execution evidence
cargo test --test run_health slow_uses_the_repositorys_last_thirty_records_and_escalates_at_twice_the_topfailed:left: String("needs you"),right: "working"for the 20-minute step-1 run.After: the same command passed:
1 passed; 0 failed.cargo test --bin thirdshift logs::reading::tests::health_testsfailed on the short-stage wake-up:11:00:24versus expected11:05:12.After: the same command passed:
2 passed; 0 failed, including exact boundaries and Spec/dispatched parent grouping.node --test --test-name-pattern='only step-2 Slow' console/tests/notifications.test.cjsfailed with actual/assets/favicon.svg, expected/assets/favicon-urgent.svg; the phone check also reproduced hidden health text.After: the same command passed:
1 passed; 0 failedat desktop and phone widths.node /tmp/issue-1465-child-slow.cjs, failed:step-1 Slow child health text must be visible in its Working Inbox row.After: that same reproduction exits 0. Retained as
console/tests/slow-children.test.cjs, covering Spec, Pass with Spec and Pass with Ticket rows at both widths.cargo test --test status inbox_puts_live_problems_first_and_points_to_silent_landing_without_duplicating_itreproduced CI's stale fixture: the two-minute run correctly appeared in Working while the test expected step-2 Slow in Needs you.After: move that ordering fixture to seven minutes for its one-minute range top, preserving every assertion. The same command passes (
1 passed), andcargo test --test statuspasses (78 passed; 1 ignored).The elapsed-time Console stream regression passed without a file change. Existing
run_healthanddismisssuites passed (30 tests; fixture entry points ignored).Final local selection:
CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 scripts/affected-tests mainpassed site checks, then stopped on a five-second sign-in navigation timeout in the existing “Run now confirms the cron Pass options and reports its skip outcome” Console test. Its exact focused rerun,node --test --test-name-pattern='Run now confirms the cron Pass options and reports its skip outcome' console/tests/start.test.cjs, passed (1 passed; 0 failed). CI on40ed0112passed formatting, clippy, the full Console and site suites, and release builds; its Rust run passed 2,334 tests before exposing the stale status fixture above. That fixture is corrected in29413d07; CI is rerunning for the latest head.Visual evidence
Direct runs, desktop 1440×900: step 1 leaves Needs you
Direct runs, phone 390×844: Slow text stays visible
Spec child, desktop 1440×900: marker in the parent summary
Spec child, phone 390×844: marker in the parent summary
Test seams
thirdshift statusandshow, text and JSON: health, Inbox membership and retained Usual ranges.Snapshot::load/evaluate_inbox: sampled times, exact transitions and parent trees.Review coverage
Against
refs/remotes/origin/main: Standards raised 1 maintenance finding; Spec raised 1 behavioral finding. Both are fixed. Of the final 21 changed files, Standards read 20 through40ed0112; Spec read 19 through97ffcbf6. Spec did not read the final fixture extraction intoconsole/tests/fixtures/run-health.cjsor its caller changes inconsole/tests/notifications.test.cjsandconsole/tests/slow-children.test.cjs; Standards read the helper and both callers. Neither axis read the final CI-driven fixture amendment intests/status.rs. No generated output was excluded; generated manual hunks were read directly.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reader policy and presentation changes; rollback restores the previous Inbox behavior.
Blast Radius: Inbox
Live health grouping, parent summaries, notification counts and favicon urgency.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh