Repository navigation
Link Review and Triage targets in compact Needs you rows - #2061
Merged
Merged
Conversation
A Triage URL that fails the origin check is still recorded under the launch repository. Compact headers and details headings keep that subject text and omit the href when it names a different issue.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compact target links work in Overview and Needs you, at desktop and phone widths, locally and across the Fleet. Ready for review keeps its existing presentation. Updated the Console README and public pages.
Closes #2043
Evidence
Execution evidence
cargo test --test triage_issue failed_issue_triage_retains_its_target_in_statusfailed:left: Null,right: 7; the failed Command had"issue":null.After: Same command passed:
1 passed; 0 failed.node --test --test-name-pattern='Needs you Review and Triage headers' console/tests/inbox.test.cjsfailed:locator.waitFor: Timeout 5000ms exceeded, waiting for the header link to/pull/301.After: Same command passed:
1 passed; 0 failed, exercising both views at 1440×900 and 390×844 and following the links directly.cargo test --test triage_pass failed_triage_pass_retains_the_issue_it_selected_in_status: passed.CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=2 cargo test --test triage_issue --test triage_pass: passed all 20 runnable tests (2 fixture entry points ignored). This first exposed stale Activity-log expectations (Triage run started/ended); the retained target correctly producesTriage run #7 started/ended. Updated those expectations and reran both complete files successfully.cargo test --test console needs_you_review_and_triage_headers_link_targets_locally_and_across_fleet: passed, including PR precedence, invalid target rejection, legacy fallbacks and Fleet subjects.CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 scripts/affected-tests mainpassed the site suite (68 tests) and locked build, then stopped on three existing Console timeouts (195 passed, 3 failed): account sign-in/config navigation and Copy fix command clipboard feedback.node --test --test-concurrency=1 --test-name-pattern='User config is editable|sign-in and sign-out|Copy fix command works' console/tests/accounts.test.cjs console/tests/inbox.test.cjs→3 passed; 0 failed.dd0c523d160312fddabd9c3a4874f68073d47891: Console, site, formatting and clippy passed. Follow-upc4640215only corrects the two Activity-log test expectations described above; final-head CI is pending. No product code changed after the passing Console/site checks.Seams tested: Triage CLI recording observed through
status --json; Console HTTP rendering with local and Fleet records; browser header visibility and direct GitHub navigation.Visual evidence
Overview, 1440×900 desktop:
Overview, 390×844 phone:
Review coverage
Independent
thirdshift-code-reviewreviewers comparedrefs/remotes/origin/main...HEAD(fixed point17c206ff11a20d8c97c0ef9ff610dd87885ae17d) and checked the final test-expectation correction in follow-up. Standards: 0 findings. Spec: 0 findings. Both read all 16 changed files. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reversible recording and presentation changes; older Command records retain their fallbacks.
Blast Radius: Console
New Triage records retain issue identity; Review and Triage Needs you subjects prefer their recorded PR.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · high