Skip to content

Link Review and Triage targets in compact Needs you rows - #2061

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-2043
Nov 11, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-2043

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Existing-issue Triage starts → retain selected issue in Command record
Needs you Review/Triage header → recorded PR → recorded issue → repository/Command

Compact target links work in Overview and Needs you, at desktop and phone widths, locally and across the Fleet. Ready for review keeps its existing presentation. Updated the Console README and public pages.

Closes #2043

Evidence

Execution evidence

  • Before: cargo test --test triage_issue failed_issue_triage_retains_its_target_in_status failed: left: Null, right: 7; the failed Command had "issue":null.
    After: Same command passed: 1 passed; 0 failed.
  • Before: node --test --test-name-pattern='Needs you Review and Triage headers' console/tests/inbox.test.cjs failed: locator.waitFor: Timeout 5000ms exceeded, waiting for the header link to /pull/301.
    After: Same command passed: 1 passed; 0 failed, exercising both views at 1440×900 and 390×844 and following the links directly.
  • cargo test --test triage_pass failed_triage_pass_retains_the_issue_it_selected_in_status: passed.
  • CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=2 cargo test --test triage_issue --test triage_pass: passed all 20 runnable tests (2 fixture entry points ignored). This first exposed stale Activity-log expectations (Triage run started/ended); the retained target correctly produces Triage run #7 started/ended. Updated those expectations and reran both complete files successfully.
  • cargo test --test console needs_you_review_and_triage_headers_link_targets_locally_and_across_fleet: passed, including PR precedence, invalid target rejection, legacy fallbacks and Fleet subjects.
  • Final local selection: CARGO_INCREMENTAL=0 CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 scripts/affected-tests main passed the site suite (68 tests) and locked build, then stopped on three existing Console timeouts (195 passed, 3 failed): account sign-in/config navigation and Copy fix command clipboard feedback.
  • All three failures passed in isolation: node --test --test-concurrency=1 --test-name-pattern='User config is editable|sign-in and sign-out|Copy fix command works' console/tests/accounts.test.cjs console/tests/inbox.test.cjs → 3 passed; 0 failed.
  • CI on product commit dd0c523d160312fddabd9c3a4874f68073d47891: Console, site, formatting and clippy passed. Follow-up c4640215 only corrects the two Activity-log test expectations described above; final-head CI is pending. No product code changed after the passing Console/site checks.

Seams tested: Triage CLI recording observed through status --json; Console HTTP rendering with local and Fleet records; browser header visibility and direct GitHub navigation.

Visual evidence

Overview, 1440×900 desktop:

Before desktop
After desktop

Overview, 390×844 phone:

Before phone
After phone

Review coverage

Independent thirdshift-code-review reviewers compared refs/remotes/origin/main...HEAD (fixed point 17c206ff11a20d8c97c0ef9ff610dd87885ae17d) and checked the final test-expectation correction in follow-up. Standards: 0 findings. Spec: 0 findings. Both read all 16 changed files. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Reversible recording and presentation changes; older Command records retain their fallbacks.

Blast Radius: Console

New Triage records retain issue identity; Review and Triage Needs you subjects prefer their recorded PR.

Built with codex codex-cli 0.167.1 · gpt-6.1-sol · high

A Triage URL that fails the origin check is still recorded under the launch
repository. Compact headers and details headings keep that subject text and
omit the href when it names a different issue.
@JacobStephens2 JacobStephens2 added the in-progress A Claim: thirdshift has taken this issue label Nov 11, 2026
@JacobStephens2
JacobStephens2 merged commit 3e7b050 into main Nov 11, 2026
@JacobStephens2
JacobStephens2 deleted the issue-2043 branch November 11, 2026 20:28
@JacobStephens2 JacobStephens2 removed the in-progress A Claim: thirdshift has taken this issue label Nov 11, 2026
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

link to the PR if present or issue if no PR in the Needs You part of the console for triage and review runs

1 participant