Repository navigation
Exclude Suspended time from Slow and Silent - #2060
Merged
Merged
Conversation
# Conflicts: # docs/guide.md # site/architecture/index.html # site/docs/index.html
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep pre-suspension work counted in
status, the Console's Inbox and Needs you. Suspension alone adds no row or Dismissal target. Older records without Suspended time retain their behavior.Closes #2033
Evidence
Execution evidence
Seams under test: binary
status/show, Console HTTP Inbox with live fixture Commands, Snapshot health and transition deadlines through filesystem activity, and recording through scripted clocks and the native file adapter.Before:
cargo test --test run_health slow_leaves_out_suspended_time_without_resetting_work_before_wakefailed:left: String("slow"),right: "ok"; a 65-minute stage with 60 suspended minutes showed step 2,6× usual.After: the same command passed:
1 passed; 0 failed.Before:
cargo test --test run_health silent_leaves_out_only_suspensions_since_the_logs_last_grewfailed:left: String("silent"),right: "ok", reporting 3900 quiet seconds.After: the same command passed:
1 passed; 0 failed.Before:
cargo test --bin thirdshift wake_annotation_keeps_silent_work_and_real_output_clears_itfailed after the wake line:left: false,right: true.After: the same regression passed:
1 passed; 0 failed. It retains 840 quiet working seconds across own and nested relayed annotations; genuine output clears Silent.cargo test --test console suspended_time_health_agrees_in_status_and_the_console_inbox:1 passed; 0 failed, covering eight healthy/Slow/Silent/CI-watch cases, row groups and Dismiss controls.cargo clippy --all-targets -- -D warningsandcargo fmt --all -- --check: passed.CI
cargo nextest runon pushed head77444aa2: 4,243 passed, 97 skipped. Compilation took 1 min 41 sec; test execution took 1,498.266 sec. Site and Console CI passed; all applicable PR checks are green.Local final selection:
NEXTEST_TEST_THREADS=3 CARGO_BUILD_JOBS=2 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/issue-2026passed all 68 site tests (221.56 sec). The duplicate localcargo nextest runwas intentionally interrupted at 2,261.98 sec, including compilation, after CI passed the exact head; its result is reused asdocs/testing.mdpermits. Focused regressions above also passed locally.Visual evidence
Architecture documentation, 1440×900:
Architecture documentation, 390×844:
Generated manual, 1440×900:
Generated manual, 390×844:
Review coverage
Independent Standards and Spec reviews used
git diff refs/remotes/origin/issue-2026...HEAD, including one follow-up per axis. Standards raised 2 findings; Spec raised 1. All addressed. Both axes read all 13 changed files, including the generated manual; no generated exclusions and no unread changed files. Reports and counts are retained in the session's.thirdshift-review-sgaQT0/artifacts.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the change to restore the previous health calculation. Suspension interval fields are optional.
Blast Radius: health
Affects live Slow/Silent state, escalation and wake deadlines across status and Console views. Stage display times remain wall-clock times.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh