Repository navigation
Explain Suspended time in stage views and exclude it from Usual ranges - #2059
Merged
Merged
Conversation
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2034.
Evidence
Execution evidence
cargo test --test status usual_ranges_leave_out_suspended_stages_and_keep_legacy_and_zero_samplesBefore: FAILED; implement bounds were
150.0–375.0seconds and the all-suspended Repair stage incorrectly had a120.0–120.0range.After:
1 passed; 0 failed. Bounds are120.0–240.0; legacy and explicit-zero samples count, clean stages in suspended Commands count, and all-suspended stages have no range.cargo test --test console time_pages_and_command_details_explain_suspended_wall_clock_stage_timesBefore: FAILED on
/stages: annotation countleft: 0,right: 1.After:
1 passed; 0 failed; checks Stages, Lanes and Command details, including ordinary stages and full wall-clock seconds.cargo test --test run_health status_explains_suspended_stage_time_without_changing_its_wall_clock_ageBefore: FAILED; output ended with
implement · 10 hr 6 min, missing the recorded suspension.After:
1 passed; 0 failed; positive Suspended time is annotated, zero and legacy stages add nothing, and the wall-clock age is retained.show_explains_suspended_stage_time_in_text_and_json_and_reads_legacy_stageschecks36360stage seconds,606stage minutes and607total minutes throughmetrics --json.cargo test --test status --test console --test run_health --test show_logs: 400 passed; 0 failed (four ignored subprocess entry points).CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 scripts/affected-tests refs/remotes/origin/issue-2026: site tests (68 tests) andcargo build --lockedpassed. The local Console run had 196 passed, 1 failed: the existing “Start Fix run forwards only to the owning machine with its current run permission” flow timed out inpage.waitForURLafter 5000 ms. The selector stopped before running the Rust suite.node --test --test-name-pattern='^Start Fix run forwards only to the owning machine with its current run permission$' console/tests/start.test.cjs: 1 passed; 0 failed, rerunning that exact flow.d201c8df315ebd8f60f35d9b2303a16ecf30b1c8: the full Rust suite (cargo nextest run), the full Console browser suite, site tests, formatting and clippy. Reused the successful full-suite CI result for this exact head, as the repository's testing guidance requires.Visual evidence
Stages, 1440×900:
Stages, 390×844:
Command details, 1440×900:
Command details, 390×844:
Test seams
show --jsonover fixture Command records: stage annotations and wall-clock durations.statustext and JSON over a live fixture Command: timed stage annotation with legacy and explicit-zero compatibility.status --all --jsonandmetrics <command> --jsonover fixture records: Usual range samples, insufficient samples, and wall-clock Run metrics.Review coverage
Independent Standards and Spec reviews against
refs/remotes/origin/issue-2026: 0 Standards findings; 0 Spec findings. Both read all 13 changed files, including generatedsite/docs/index.html. Generated-output exclusions: none. Unread changed files: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Read-only display and sample selection; no record migration.
Blast Radius: observability
Stage annotations and Usual ranges on this machine; Run metrics retain wall-clock time.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh