Repository navigation
Resume all-closed Specs through Pickup - #2003
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse ADR-0002's latest branch and newest PR facts. No PR or an open PR qualifies; missing branches and finished PRs do not. Preserve hand-back, trust, settling, blocker, reservation and Claim gates. Architect gives the same Specs priority, including while settling. Update the glossary, manual and hand-written site wording.
Closes #1964
Seams under test: the
thirdshift pickupandthirdshift architectCLIs with real Git repositories and fakegh/Harness processes; observable sessions, PR Delivery, labels and reservation refs.Evidence
Execution evidence
cargo test --test pickup_run pickup_continues_an_all_closed_spec_through_review_and_delivery -- --exact --nocapturefailed:no PR from issue-7: [];0 passed; 1 failed.After: the same command passed:
1 passed; 0 failed. Both no-PR and open-PR cases perform one Spec review, run no Ticket again, deliver a ready PR, clear the Claim and release the reservation.npm test --prefix site: 68 passed, 0 failed, including manual regeneration and desktop/mobile browser checks./usr/bin/time -p scripts/affected-tests refs/remotes/origin/main: passed. Site: 68 passed. Rust:cargo nextest run, 4,204 passed, 97 skipped; 3,505.85 seconds including compilation (3m 31s), with 3,292.946 seconds executing tests. Full entry point: 3,657.83 seconds wall time.cargo test --bin thirdshift branch::tests: 18 passed;cargo test --bin thirdshift ready::tests: 31 passed. The explicit CLI regressions for Tickets closing between reads/after reservation and continuing the latest numbered branch also passed.cargo test --locked --test pickup_model -- --nocapture: 4 passed, 1 ignored. The explicit literal assertion and both safeguard mutations returned the expected counterexamples. The known pre-Claim duplicate-dispatch counterexample remains; this is evidence about claimed-dispatch safety, not proof of the literal property. Continuation eligibility and branch/Ticket read races are covered by CLI regressions rather than the model.cargo fmt --check: passed. CI passed for head47bf9f4e, including Rust, site and Console checks.Visual evidence
Spec coordination, 1440×900
Spec coordination, 390×844
Pickup selection rules, 1440×900
Pickup selection rules, 390×844
Merge Danger
Door: two-way
Revert restores the former selection rule; no persistent data migration.
Blast Radius: scheduling
Shared readiness also affects Architect priority and Security's Ready-issue gate. Only all-closed Specs with eligible continuation branches gain eligibility.
Unaddressed findings
Standards
None. Independent review raised 0 findings.
Spec
None. Independent review raised 0 findings.
Security
None. Guidance review of the pickup continuation change found no introduced security finding.
Review coverage: both axes read all 8 changed files, including
site/docs/index.html. No generated-output exclusions; no changed file was left unread. Reports andsummary.jsonare retained in.thirdshift-review-tcENaZ/with the Session evidence.Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.