Skip to content

Resume all-closed Specs through Pickup - #2003

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1964
Nov 11, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1964

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ready Spec
  open Tickets → require a Startable Ticket
  all Tickets closed → require a resumable latest Spec branch on origin
    reserve → refresh → Claim → Spec review → Delivery / Repair

Reuse ADR-0002's latest branch and newest PR facts. No PR or an open PR qualifies; missing branches and finished PRs do not. Preserve hand-back, trust, settling, blocker, reservation and Claim gates. Architect gives the same Specs priority, including while settling. Update the glossary, manual and hand-written site wording.

Closes #1964

Seams under test: the thirdshift pickup and thirdshift architect CLIs with real Git repositories and fake gh/Harness processes; observable sessions, PR Delivery, labels and reservation refs.

Evidence

Execution evidence

  • Before: cargo test --test pickup_run pickup_continues_an_all_closed_spec_through_review_and_delivery -- --exact --nocapture failed: no PR from issue-7: []; 0 passed; 1 failed.
    After: the same command passed: 1 passed; 0 failed. Both no-PR and open-PR cases perform one Spec review, run no Ticket again, deliver a ready PR, clear the Claim and release the reservation.
  • Focused all-closed CLI and unit checks passed, including Architect priority, missing or finished branches, absent hand-back, empty later Ticket reads and branch loss after reservation.
  • npm test --prefix site: 68 passed, 0 failed, including manual regeneration and desktop/mobile browser checks.
  • /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main: passed. Site: 68 passed. Rust: cargo nextest run, 4,204 passed, 97 skipped; 3,505.85 seconds including compilation (3m 31s), with 3,292.946 seconds executing tests. Full entry point: 3,657.83 seconds wall time.
  • cargo test --bin thirdshift branch::tests: 18 passed; cargo test --bin thirdshift ready::tests: 31 passed. The explicit CLI regressions for Tickets closing between reads/after reservation and continuing the latest numbered branch also passed.
  • cargo test --locked --test pickup_model -- --nocapture: 4 passed, 1 ignored. The explicit literal assertion and both safeguard mutations returned the expected counterexamples. The known pre-Claim duplicate-dispatch counterexample remains; this is evidence about claimed-dispatch safety, not proof of the literal property. Continuation eligibility and branch/Ticket read races are covered by CLI regressions rather than the model.
  • cargo fmt --check: passed. CI passed for head 47bf9f4e, including Rust, site and Console checks.

Visual evidence

Spec coordination, 1440×900

Before
After

Spec coordination, 390×844

Before
After

Pickup selection rules, 1440×900

Before
After

Pickup selection rules, 390×844

Before
After

Merge Danger

Door: two-way

Revert restores the former selection rule; no persistent data migration.

Blast Radius: scheduling

Shared readiness also affects Architect priority and Security's Ready-issue gate. Only all-closed Specs with eligible continuation branches gain eligibility.

Unaddressed findings

Standards

None. Independent review raised 0 findings.

Spec

None. Independent review raised 0 findings.

Security

None. Guidance review of the pickup continuation change found no introduced security finding.

Review coverage: both axes read all 8 changed files, including site/docs/index.html. No generated-output exclusions; no changed file was left unread. Reports and summary.json are retained in .thirdshift-review-tcENaZ/ with the Session evidence.

Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.

@JacobStephens2
JacobStephens2 merged commit fbbec4a into main Nov 11, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1964 branch November 11, 2026 04:18
This was referenced Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pickup passes over a Ready Spec whose Tickets are all closed, even when its Spec PR needs work

1 participant