Skip to content

Show live Fix and Review targets in Working rows - #2002

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-1963
Nov 11, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-1963

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Live Fix and Review targets are visible in compact Working rows, including Overview, for local and Fleet Commands.

 acme/widgets · Review run
+PR #41 (clickable)
 acme/widgets · Fix run
+Base branch release/2026.11
+PR #44 (once published)

Base branch CI repairs persist an optional base_branch before the session starts. Older records retain useful fallbacks. Updated the manual and relevant hand-written site pages.

Closes #1963

Evidence

Execution evidence

Test seams: the Console in Chromium (including real Fleet transport), and the public Fix Pass with status --local --json during a held repair and after publication.

  • Before: node --test console/tests/working-targets.test.cjs failed: 1440px dev.etadventures.com review-explicit: visible PR target, false !== true (0 passed, 1 failed).
    After: the same command passed (1 passed, 0 failed), checking JavaScript-enabled 1440×900 and 390×844 Overview/Working rows, simultaneous Review targets, explicit and Pass-selected Fix targets, legacy records, and exact Base branch visibility before and after publication.
  • Before: cargo test --test fix_base_ci named_base_with_no_rerunnable_jobs_repairs_its_origin_tip failed: left: Null, right: "release" (0 passed, 1 failed).
    After: the same command passed (1 passed, 0 failed), retaining the selected Base branch and resulting PR.
  • cargo test --test console a_live_review_run_links_its_pull_request_in_working: passed.
  • node --test console/tests/inbox.test.cjs console/tests/fleet.test.cjs console/tests/working-targets.test.cjs: 97 passed, 0 failed, including preservation of existing subject text and Ready for review behavior.
  • npm run docs:check --prefix site: passed.
  • Final scripts/affected-tests main run: build, site (68 tests), and Console (197 tests) passed on merged head af301ea1, with browser workers limited to two. Reused the successful full Rust CI result for that exact head and stopped the redundant local Rust run, following docs/testing.md.
  • CI on af301ea1 passed formatting, clippy, site, Console, and the full Rust nextest suite: 4,197 passed, 97 skipped. The nextest run took 1,117.389 seconds; compilation took 61 seconds on the CI runner.

Visual evidence

Overview with local and Fleet Review/Fix targets, 1440×900:

Before
After

Same Overview state, 390×844:

Before
After

Review coverage

Independent Standards and Spec reviews against refs/remotes/origin/main (6bcde72587fe5a82146801f0d1e489b183e5b45b) raised 0 findings each. Both axes read all 16 changed files, including generated site/docs/index.html. The merge with the latest main preserves its Ticket-completion counter alongside this change's targets. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

The optional record field is backward compatible; the presentation can be reverted.

Blast Radius: Console

Changes live Fix/Review row targets and Base branch repair metadata.

Built with codex codex-cli 0.167.1 · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit a53a6d1 into main Nov 11, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1963 branch November 11, 2026 03:45
This was referenced Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant