Repository navigation
Show live Fix and Review targets in Working rows - #2002
Merged
Merged
Conversation
# Conflicts: # docs/guide.md # site/docs/index.html # src/console/row.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live Fix and Review targets are visible in compact Working rows, including Overview, for local and Fleet Commands.
Base branch CI repairs persist an optional
base_branchbefore the session starts. Older records retain useful fallbacks. Updated the manual and relevant hand-written site pages.Closes #1963
Evidence
Execution evidence
Test seams: the Console in Chromium (including real Fleet transport), and the public Fix Pass with
status --local --jsonduring a held repair and after publication.node --test console/tests/working-targets.test.cjsfailed:1440px dev.etadventures.com review-explicit: visible PR target,false !== true(0 passed, 1 failed).After: the same command passed (1 passed, 0 failed), checking JavaScript-enabled 1440×900 and 390×844 Overview/Working rows, simultaneous Review targets, explicit and Pass-selected Fix targets, legacy records, and exact Base branch visibility before and after publication.
cargo test --test fix_base_ci named_base_with_no_rerunnable_jobs_repairs_its_origin_tipfailed:left: Null,right: "release"(0 passed, 1 failed).After: the same command passed (1 passed, 0 failed), retaining the selected Base branch and resulting PR.
cargo test --test console a_live_review_run_links_its_pull_request_in_working: passed.node --test console/tests/inbox.test.cjs console/tests/fleet.test.cjs console/tests/working-targets.test.cjs: 97 passed, 0 failed, including preservation of existing subject text and Ready for review behavior.npm run docs:check --prefix site: passed.scripts/affected-tests mainrun: build, site (68 tests), and Console (197 tests) passed on merged headaf301ea1, with browser workers limited to two. Reused the successful full Rust CI result for that exact head and stopped the redundant local Rust run, followingdocs/testing.md.af301ea1passed formatting, clippy, site, Console, and the full Rust nextest suite: 4,197 passed, 97 skipped. The nextest run took 1,117.389 seconds; compilation took 61 seconds on the CI runner.Visual evidence
Overview with local and Fleet Review/Fix targets, 1440×900:
Same Overview state, 390×844:
Review coverage
Independent Standards and Spec reviews against
refs/remotes/origin/main(6bcde72587fe5a82146801f0d1e489b183e5b45b) raised 0 findings each. Both axes read all 16 changed files, including generatedsite/docs/index.html. The merge with the latestmainpreserves its Ticket-completion counter alongside this change's targets. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The optional record field is backward compatible; the presentation can be reverted.
Blast Radius: Console
Changes live Fix/Review row targets and Base branch repair metadata.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · high