Repository navigation
Show Ticket completion in the Console Inbox - #2000
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inbox overview row (Spec or dispatching Pass) state · subject · title · age + 2 / 5 Tickets complete · stage and healthCount recorded merged Tickets, including preclosed Tickets, independently of child attempts. Refresh through existing record updates and use the owning machine's Fleet records. Omit empty accounting and retain the last count after a run ends; Spec review and Delivery keep their own state.
Closes #1848
Test seams: Console HTTP row presentation; Inbox rendering and record updates in Chromium; Fleet presentation from owning-machine records.
Evidence
Execution evidence
cargo test --test console overview_ticket_progress_counts_recorded_states_and_omits_missing_accounting→test inbox::overview_ticket_progress_counts_recorded_states_and_omits_missing_accounting ... FAILED; the rendered row lacked2 / 6 Tickets complete.After: Same command →
test result: ok. 1 passed; 0 failed.THIRDSHIFT_CONSOLE_ASSETS=/home/jacob/repos/thirdshift-issue-1848/src/console/assets node --test --test-name-pattern='Ticket progress' console/tests/inbox.test.cjs→locator.waitFor: Timeout 5000ms exceeded, waiting for6 / 6 Tickets completeon the visible Pass row.After: Same command →
tests 1,pass 1,fail 0; covers mixed states, stage/health visibility, record updates, dispatched Specs, retained ended accounting, desktop and phone across six Themes.cargo fmt --checkandnpm run docs:check --prefix sitepassed.CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 scripts/affected-tests mainpassed. Full Rust checks passed all 4,183 selected tests (97 skipped), taking 3,586.57 seconds including compilation on the shared four-core host.AssertionError: one line per row. After tightening desktop row spacing,THIRDSHIFT_CONSOLE_ASSETS=/home/jacob/repos/thirdshift-issue-1848/src/console/assets node --test --test-name-pattern='every section folder fits|Ticket progress' console/tests/inbox.test.cjspassed both tests.Visual evidence
1440×900 desktop, Overview with a Spec and a Pass-dispatched Spec:
390×844 phone, same Overview rows scrolled into view:
Review coverage
Independent
thirdshift-code-reviewagainstrefs/remotes/origin/main(merge-basedbdd8943): Standards 0 findings; Spec 0 findings. Both axes read all 12 changed files, including the generated manual paragraph, and reviewed the spacing follow-up. Generated-output exclusions: none. Changed files left unread: none. The latestorigin/maingives the same three-dot diff and merges cleanly.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Presentation and documentation changes; no stored-record migration or new GitHub reads.
Blast Radius: Console
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh