Skip to content

Show Ticket completion in the Console Inbox - #2000

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-1848
Nov 11, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-1848

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Inbox overview row (Spec or dispatching Pass)
   state · subject · title · age
+  2 / 5 Tickets complete · stage and health

Count recorded merged Tickets, including preclosed Tickets, independently of child attempts. Refresh through existing record updates and use the owning machine's Fleet records. Omit empty accounting and retain the last count after a run ends; Spec review and Delivery keep their own state.

Closes #1848

Test seams: Console HTTP row presentation; Inbox rendering and record updates in Chromium; Fleet presentation from owning-machine records.

Evidence

Execution evidence

  • Before: cargo test --test console overview_ticket_progress_counts_recorded_states_and_omits_missing_accounting → test inbox::overview_ticket_progress_counts_recorded_states_and_omits_missing_accounting ... FAILED; the rendered row lacked 2 / 6 Tickets complete.
    After: Same command → test result: ok. 1 passed; 0 failed.
  • Before: THIRDSHIFT_CONSOLE_ASSETS=/home/jacob/repos/thirdshift-issue-1848/src/console/assets node --test --test-name-pattern='Ticket progress' console/tests/inbox.test.cjs → locator.waitFor: Timeout 5000ms exceeded, waiting for 6 / 6 Tickets complete on the visible Pass row.
    After: Same command → tests 1, pass 1, fail 0; covers mixed states, stage/health visibility, record updates, dispatched Specs, retained ended accounting, desktop and phone across six Themes.
  • cargo fmt --check and npm run docs:check --prefix site passed.
  • Selected site checks passed all 68 tests; Console browser checks passed all 186 tests, including Fleet control and owning-machine counter updates.
  • Final validation: CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=3 scripts/affected-tests main passed. Full Rust checks passed all 4,183 selected tests (97 skipped), taking 3,586.57 seconds including compilation on the shared four-core host.
  • The existing desktop compactness check initially failed with AssertionError: one line per row. After tightening desktop row spacing, THIRDSHIFT_CONSOLE_ASSETS=/home/jacob/repos/thirdshift-issue-1848/src/console/assets node --test --test-name-pattern='every section folder fits|Ticket progress' console/tests/inbox.test.cjs passed both tests.

Visual evidence

1440×900 desktop, Overview with a Spec and a Pass-dispatched Spec:

Before
After

390×844 phone, same Overview rows scrolled into view:

Before
After

Review coverage

Independent thirdshift-code-review against refs/remotes/origin/main (merge-base dbdd8943): Standards 0 findings; Spec 0 findings. Both axes read all 12 changed files, including the generated manual paragraph, and reviewed the spacing follow-up. Generated-output exclusions: none. Changed files left unread: none. The latest origin/main gives the same three-dot diff and merges cleanly.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Presentation and documentation changes; no stored-record migration or new GitHub reads.

Blast Radius: Console

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 6bcde72 into main Nov 11, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1848 branch November 11, 2026 02:34
This was referenced Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add way to display x / y sub-issues complete when viewing a spec run on the console web ui /?section=overview

1 participant