Repository navigation
Console: start Fix runs from Ready for review rows - #1986
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuses the existing scoped start API and Fleet forwarding. Other-account Commands remain read-only; live refresh preserves confirmation controls, pending protection and uncertain-response feedback.
Closes #1788
Evidence
Execution evidence
Test seams: Console browser interactions and the HTTP start API, including real Fleet forwarding.
PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test --test-name-pattern='Start Fix run confirms' console/tests/start.test.cjsnode --test console/tests/start.test.cjs: 14 tests passed on the final head.PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright CARGO_BUILD_JOBS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main: local site 68 passed (146.41s), build passed (0.58s), and Console 190 passed (196.75s). The remote ref is the actual PR base and review fixed point; localmainis stale. The duplicate local Rust run was stopped after CI passed on the exact same head.a3c0befdpassed formatting,cargo clippy --all-targets -- -D warnings, andcargo nextest run:Visual evidence
Ready for review row, 1440×900:
Ready for review row, 390×844:
Review coverage
Independent
thirdshift-code-reviewagainstrefs/remotes/origin/main(dbdd8943), including the follow-up througha3c0befd: Standards 0 findings, Spec 0 findings. Each axis read all 16 changed files, including the generated manual. No generated-output exclusions. Unread changed files: none under either axis.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Console
The new control submits through existing authorization and CLI admission after explicit confirmation. No authorization rules change.
Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh