Skip to content

Console: start Fix runs from Ready for review rows - #1986

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1788
Nov 11, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1788

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ready for review + (CI red or Merge conflict)
  Copy fix command
  Start Fix run (current run permission + known Launch directory)
    Confirm PR, repository and owning machine
    Start there with User config and CLI defaults

Reuses the existing scoped start API and Fleet forwarding. Other-account Commands remain read-only; live refresh preserves confirmation controls, pending protection and uncertain-response feedback.

Closes #1788

Evidence

Execution evidence

Test seams: Console browser interactions and the HTTP start API, including real Fleet forwarding.

  • Before: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test --test-name-pattern='Start Fix run confirms' console/tests/start.test.cjs
    not ok 1 - Start Fix run confirms the pull request and defaults, cancels, and submits once
    locator.click: Timeout 5000ms exceeded.
    waiting for getByRole('button', { name: 'Start Fix run', exact: true })
    # pass 0
    # fail 1
    
    After: the same command passes:
    ok 1 - Start Fix run confirms the pull request and defaults, cancels, and submits once
    # pass 1
    # fail 0
    
  • All five new browser scenarios pass: exact targeted request and CSRF, Cancel/Escape, eligibility and current permissions, unknown Launch directory, repository URL casing, live row insertion/replacement, pending submission, uncertain responses, and real owning-machine forwarding at desktop and phone widths.
  • Targeted HTTP checks cover run scope, CSRF and unknown repository refusal, Other-account exclusion, and existing Fix requester attribution.
  • node --test console/tests/start.test.cjs: 14 tests passed on the final head.
  • PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright CARGO_BUILD_JOBS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main: local site 68 passed (146.41s), build passed (0.58s), and Console 190 passed (196.75s). The remote ref is the actual PR base and review fixed point; local main is stale. The duplicate local Rust run was stopped after CI passed on the exact same head.
  • Full CI on a3c0befd passed formatting, cargo clippy --all-targets -- -D warnings, and cargo nextest run:
    Summary [1060.928s] 4184 tests run: 4184 passed (2 slow), 97 skipped
    
    The Rust step took 1,119s including 57.58s compilation. Site and Console CI jobs passed too.

Visual evidence

Ready for review row, 1440×900:

Before desktop
After desktop

Ready for review row, 390×844:

Before phone
After phone

Review coverage

Independent thirdshift-code-review against refs/remotes/origin/main (dbdd8943), including the follow-up through a3c0befd: Standards 0 findings, Spec 0 findings. Each axis read all 16 changed files, including the generated manual. No generated-output exclusions. Unread changed files: none under either axis.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Blast Radius: Console

The new control submits through existing authorization and CLI admission after explicit confirmation. No authorization rules change.

Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 960513a into main Nov 11, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1788 branch November 11, 2026 00:59
This was referenced Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console: start a Fix run from a Ready for review row

1 participant