Repository navigation
Keep Passes clear of live Experiments - #1982
Merged
Merged
Conversation
# Conflicts: # GLOSSARY.md # site/architecture/index.html
JacobStephens2
marked this pull request as draft
November 11, 2026 01:08
2026-11-11T01:08:35Z, host orchestrate.etadventures.com. Uncommitted work at the time of failure is included in this commit.
2026-11-11T17:33:24Z, host dev.etadventures.com. Uncommitted work at the time of failure is included in this commit.
Owner
Author
The Day shift approved recovery of this existing PR through one targeted Fix on Lima, with self-merge disabled, leaving it ready for review. The recovery brief on #1494 preserves the previously agreed behavior and records the interrupted salvage and validation requirements. Keep #1494 out of Pickup during this recovery: a Fix reserves this PR, not its closing issue. Inspect the salvaged head, reconcile current main and remote branch changes, and validate the final head. Prior green CI on |
JacobStephens2
marked this pull request as ready for review
November 11, 2026 17:55
# Conflicts: # src/command_limit.rs # src/logs.rs # src/logs/recording.rs # src/main.rs
Quota admission from main probed GitHub (api rate_limit, api user) before the live-Experiment check, so a Pass made GitHub calls it should skip.
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep factory work from competing with Experiment Trials on the same machine and OS account.
Waiting Experiments take turns. Stop and resume preserve the normal interrupted lifecycle. Status and the Console name the remaining Commands, and Experiment results format 11 shows the bypass count beside the Verdict.
Closes #1494
Evidence
Execution evidence
Recovery validation — current head
6c2ce8ef6fd8570472300ff31e45d2481c6484eb: Lima Fix runfix-20261111T125448-0500completed with outcome ready for review on 2026-11-11. It reconciled the branch with main, completed two Repair sessions, and verified the PR was open, ready and mergeable. CI passed the Rust test, Console and site jobs on this head. Release passed, including both Linux artifact builds. Jobs excluded by the workflows' gates were skipped. Self-merge was disabled.The detailed implementation checks below were recorded before this recovery:
cargo test --test experiments host:: -- --nocapturefailed withthirdshift: --no-wait requires a value.After: the same command passes all six host coordination regressions, covering all seven Pass kinds, manual Ticket and Custom process warnings, waiting and refreshed blockers, Stop/resume, competing Experiments and bypass counts.
cargo test --test process a_process_with_an_issue_fills_a_slot_so_a_pickup_run_runs_beside_it_only_above_a_command_limit_of_1 -- --exact --nocapturefailed: Pickup returnedhttps://github.com/acme/widgets/pull/1at a Command limit of one.After: the same command passes. Both other behavioral review reproductions were also run exactly as supplied: the waiting-Experiment cycle and omitted text-status blocker failed before their fixes and passed afterward. Their tests are retained.
cargo clippy --all-targets -- -D warningspasses.cargo test --test activity_log an_activity_log_that_cannot_be_written_is_one_warning_and_changes_nothing_else -- --exact --nocapturefailed with two warnings instead of one. After: the same test passes; admission now reads Command records without depending on Activity-log contents. The entire Activity log suite also passes (16 tests, one ignored fixture entry).cargo test --test command_surfacefound 71 logical help lines against the 68-line limit;cargo test --test packaging non_linux_compilation_reports_only_the_platform_error -- --exact --nocapturefound four diagnostics instead of the one unsupported-platform message. After: the Command surface suite passes (20 tests, one ignored fixture entry; help is 68 lines), and the exact packaging regression passes. The lock module now uses the same Linux gate as surrounding modules.RUST_TEST_THREADS=3 CARGO_BUILD_JOBS=3 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main, with the documented Chromium setup and a stableTHIRDSHIFT_BINARYsnapshot. Site passed (94.41s), locked build passed (114.63s, compilation included), then Console finished 186/187 with a five-second timeout in the existing phone Dismiss case. Its exact focused rerun passed:node --test --test-name-pattern='^Inbox row Dismiss works in ready for review with JavaScript on a phone$' console/tests/inbox.test.cjs. A prior local Sections assertion also passed its exact focused rerun. The complete Console CI suite passed on implementation head345a2affbefore recovery.345a2aff: CI and Release pass.cargo nextest runpassed all 4,181 tests (97 skipped): 1,216.160s execution, with test compilation included in the 1,284s step. Formatting, clippy, generator checks, and the complete site and Console suites pass. These exact-head CI results supply full-suite validation; the local selector stopped at the browser timeout described above.Visual evidence
These captures document the implementation before recovery. Before captures use
mainat0009a536; After captures use the then-reconciled branch. Every pair uses the same viewport and fixture state. Media is stored in a secret Gist and kept out of repository branches.Experiment waiting for a Command
Desktop · 1440×900
Mobile · 390×844
Competing Command count beside the Verdict
Desktop · 1440×900
Mobile · 390×844
Waiting Command names in the Inbox
Desktop · 1440×900
Mobile · 390×844
Experiment instructions in the manual
Desktop · 1440×900
Mobile · 390×844
Experiments on the homepage
Desktop · 1440×900
Mobile · 390×844
Experiment scheduling in the guide
Desktop · 1440×900
Mobile · 390×844
Experiment scheduling in the architecture page
Desktop · 1440×900
Mobile · 390×844
Test seams
Review
The review coverage below was recorded through implementation head
345a2aff. Recovery validation for current head6c2ce8eis listed above; a fresh review of the recovery changes remains part of PR review.Reviewed against
refs/remotes/origin/main, with the reconciled merge-base pinned to0009a536. Standards raised one finding; Spec raised three. All four are addressed. Supplemental reviews cover the CI corrections, fresh final reviews cover the reconciled head20aa5bb2, and both axes inspected the platform correction in implementation head345a2aff; no new findings were raised. Combined coverage includes all 33 changed files and generated HTML. Changed files left unread: none. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Existing records remain readable through defaults. Consumers of the versioned Experiment JSON need format 11 support.
Blast Radius: scheduling
All Pass kinds now skip during a live Experiment on this account and machine. Already running Commands continue; targeted Commands can still compete after a warning.
Built with claude 2.1.314 · opus · default effort