Repository navigation
Publish Console browser fixture records atomically - #1978
Merged
Merged
Conversation
This was referenced Nov 11, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish Command records atomically in the seven remaining browser files and the fixture helper invoked by the spans tests. Convert setup writes for consistency and retain log, Session-trace and configuration writes.
Closes #1350
Evidence
Execution evidence
The held-write regression pauses the title-only update after truncation, refreshes all three tabs, and waits for the shared notification count to sample the result. A partial published record was skipped by the reader, causing a false fall followed by a rise when the complete record returned. Replacing a temporary file leaves the earlier complete record readable until rename.
Before and after command (Chromium installed in the private cache shown):
PLAYWRIGHT_BROWSERS_PATH=/tmp/thirdshift-1350-browsers.ceq7Vs node --require ./console/reproductions/notification-record-write.cjs --test --test-name-pattern '^several tabs notify' console/tests/notifications.test.cjsRecord write held: 3 pages and shared notification count observed 1; the existing title-only assertion failed with2 !== 1(actual 2 notifications, expected 1).Record write held: 3 pages and shared notification count observed 2;# pass 1,# fail 0. The assertion that a title-only update produces no extra notification is preserved. The normal notification test also refreshes each tab before rename and checks the earlier title and count.Focused browser files:
PLAYWRIGHT_BROWSERS_PATH=/tmp/thirdshift-1350-browsers.ceq7Vs node --test --test-concurrency=2 console/tests/stop.test.cjs console/tests/notifications.test.cjs console/tests/logs.test.cjs console/tests/time.test.cjs console/tests/waterfall.test.cjs console/tests/themes-regressions.test.cjs console/tests/spans.test.cjs— 42 passed, 0 failed.Final affected checks:
PLAYWRIGHT_BROWSERS_PATH=/tmp/thirdshift-1350-browsers.ceq7Vs scripts/affected-tests refs/remotes/origin/main— passedcargo build --locked(1.69s) andnpm test --prefix console(185 passed, 0 failed; 204.60s).The initial
scripts/affected-tests mainused the stale localmainref, selected unrelated Go changes, and stopped becausegois unavailable. The rerun uses the current remotemainref used for review.Test seams: Command-record publication through the filesystem, observed through the Console's three-tab notification behavior.
Review coverage
Independent Standards and Spec reviews against
refs/remotes/origin/main(84c5856e) found 0 findings each. Both reviewers read all nine changed files; unread changed files: none. Generated-output exclusions: none. Reports and final files-read lists are retained in.thirdshift-review-UYLVk8/standards.mdandspec.md, with counts insummary.json.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Fixture-only changes; straightforward to revert.
Blast Radius: tests
Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh