Repository navigation
Deepen the Grader panel's retained-call lifecycle - #1970
Merged
Merged
Conversation
…/actions/runs?head_sha=877617c6972e90404bbfc439de9192bf686428c7&per_page=100 failed: gh: API rate limit exceeded for user ID 53905376. If you reach out to GitHub Support for help, please include the request ID BD92:16EBDD:1C93174:5996FF0:6AF37847 and timestamp 2026-11-10 20:02:15 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) (HTTP 403)) 2026-11-10T20:02:16Z, host orchestrate.etadventures.com. Uncommitted work at the time of failure is included in this commit.
JacobStephens2
marked this pull request as draft
November 10, 2026 20:02
This was referenced Nov 10, 2026
JacobStephens2
marked this pull request as ready for review
November 10, 2026 20:57
This was referenced Nov 11, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrupt retained calls now stop cost confirmation and resume before paid work, even behind an earlier missing order or with
--yes. Saved filenames, JSON, voting, fixed executables and per-run spending policy stay compatible. Resume documentation and the domain-to-code index describe the shared owner.Closes #1968
Evidence
Execution evidence
cargo test --test experiments corrupt_later_panel_calls_stop_resume_before_any_more_sessions -- --nocapturefailed with
left: 2,right: 1: a second Grader launched before malformed order 2 was reported.After: the same command passed:
1 passed; 0 failed.cargo test --test experiments panel:: -- --test-threads=3failed:14 passed; 1 failed; the new sparse-history fixture incorrectly started from a completed Experiment.After: the same command passed:
15 passed; 0 failed(100.87s), including the retained sparse multi-seat regression.cargo check --bin thirdshiftpassed.cargo test --bin thirdshift evals::experiment::panel:: -- --nocapturepassed:7 passed; 0 failed.npm run docs:check --prefix siteandcargo fmt --checkpassed.scripts/affected-tests refs/remotes/origin/mainpassed: site checks passed in 100.28s; the full Rust suite (cargo testfallback) passed in 1933.62s, including compilation (1m 16s).81eed964995fb65640f5a874963522851a72f99d, including Rust, site and Console checks. The successful full suite is reused under the repository's exact-head CI policy; no product changes were needed in this continuation.cargo test --bin thirdshift evals::experiment::panel:: -- --nocapturepassed (7 passed; 0 failed);cargo test --test experiments panel:: -- --test-threads=3passed (15 passed; 0 failed, 93.82s execution);npm run docs:check --prefix sitepassed afternpm ci --prefix site.Test seams: the retained-call
Historyinterface with Native/Observed reads and temporary storage; the Experiment CLI's cost confirmation, pause/resume and reports. Existing voting, family, counted-people, low-limit and unpriceable-session regressions are retained.Visual evidence
Manual resume documentation, same expanded Experiments section and scroll position. Before was captured from main at
6ce3c940; After shows this change.1440×900 desktop:
390×844 mobile:
Review coverage
Reviewed the whole branch from
refs/remotes/origin/main(84c5856e) on independent Standards and Spec axes: Standards 0 findings; Spec 0 findings. Both axes read all 11 changed files, including generated HTML. Changed files left unread: none. Generated-output exclusions: none. The existing sparse-history fixture correction and its regression remain in the branch.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
No saved-data migration; the refactor can be reverted.
Blast Radius: Experiments
Panel estimates, resume and reports share completion facts. Malformed or unreadable saved calls now stop earlier with pair, seat and order context.
Built with codex codex-cli 0.167.0 · gpt-6.1-sol · high