Repository navigation
Rerun a Spec: continue where the last Spec run stopped - #197
Merged
Merged
Conversation
A Spec whose Tickets are all closed and has no Spec branch stops with nothing to do, touching nothing. Tests cover a rerun after a Failed spec run, and going straight to the Spec review with every Ticket closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running a Spec again picks up where the last Spec run stopped. Most of this already worked because of earlier Spec-run work and ADR-0002. This PR adds the one missing stop and tests for every rerun case.
Help and the README "Spec runs" section now describe rerunning.
Evidence
New tests in
tests/spec_run.rs:rerunning_a_failed_spec_run_continues_the_spec_branch_and_the_failed_tickets_issue_branchissue-22with a Continuation prompt whose base isissue-20;-branch-2branches are created.with_every_ticket_closed_and_a_spec_branch_the_spec_run_goes_straight_to_the_spec_review_of_its_spec_prwith_every_ticket_closed_and_no_spec_branch_there_is_nothing_to_doissue-20, opened a Spec PR and exited 0.cargo testpasses in full (all 24 test binaries).Merge Danger
Door: two-way
Blast Radius: narrow
The new stop only applies to an issue with sub-issues, all closed, whose Issue branch selection is Fresh. Ordinary Runs and Spec runs with open Tickets are unchanged.
Unaddressed findings
Standards
run::runrather thanspec_run(possible Feature Envy). It needs the branchSelectionand has to run before any work, next to the existingparallelcheck that does the same. A single spec-run pre-work check can come later if more of these appear.parallelrejection. Issue Rerunning a Spec #149 fixes the exact wording.calls[2]in the rerun test. The file's other tests already rely on the fake's PR numbering and session order.Spec
parallelon a non-Spec). "Touching nothing" refers to the repository and GitHub.Closes #149
🤖 Generated with Claude Code