Repository navigation
Add the blind pairwise review page to the Console - #1946
Merged
Merged
Conversation
Each pair with evidence gets a blind page and a CLI twin: the Ticket, its numbered acceptance checklist, both changes side by side with code before tests, and their evidence, on sides drawn per pair from the Bar's seed. A reader seals a merge call per side before a preference and optional rubric; records are append-only and attributed. Arm identity and the panel's calls are revealed after the preference. People's calls and people-panel agreement show beside the Verdict (result format 10).
Seal a reader's merge calls until their preference, and mark a review begun after the reader's reveal as not blind, keeping it out of people-panel agreement. Document the --pair JSON and review records and check them, with people's calls and panel calls, against the result contract. Share the preference values, next-step command, reveal line and changed-path listing; read the Ticket input by its shared name and require a file. Describe the blind page on the workflow page and read its format number from the contract.
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each pair of Trials with retained evidence gets a blind page in the Console, with a CLI twin. People's calls are reported beside the Verdict.
reviews/<pair-id>/<n>.json, attributed with the sharedActor(Console signed-in reader, or the Unix user on the CLI).blind: falseand left out of agreement.PairSide.diff, optionalPair.panel,people, and the documentedPairPagethat--pair --jsonemits.Closes #1885
Evidence
Execution evidence
cargo test --test console pairwise::sealed_merge_calls_cannot_be_replaced_or_remade_after_the_reveal(the Spec reviewer's test) failed:cargo test --test console pairwise→test result: ok. 5 passed; 0 failedcargo test --test experiments pairs::each_arms_new_tests_run_on_the_base_and_the_other_arms_commit→ ok. It covers the real diff capture, plus CLI calls checked against the documentedPairPageandExperimentcontract.scripts/affected-tests origin/issue-1872on f3aa5f7:npm test --prefix site: PASSnpm test --prefix console: PASS, 171 testscargo test: PASS, 4082 passed, 0 failed, 866sconsole/node_moduleswas not installed (Cannot find module 'playwright'). They pass afternpm ci --prefix console.Visual evidence
Blind pair page, 1440×900, before any call. Before: the base Console has no such route and serves an empty 404.
Blind pair page, 390×844, before any call. The two changes stack on narrow screens.
Experiment page, 1440×900, after one CLI review. People's calls appear beside the Verdict.
Review
Reviewed with
thirdshift-code-reviewagainstrefs/remotes/origin/issue-1872: Standards found 10 findings, Spec found 7.Addressed:
people,panelandPairPage;--pairJSON and the record files are documented.ISSUE_FILEand must be a file.Review coverage: both reviewers read every changed file except
site/docs/index.html. That file is generated fromdocs/guide.md; it was excluded withnpm run docs:check --prefix sitepassing, and was left unread by both axes. The review covered commits 934eb93 and bdfabac. The fix commit f3aa5f7 was not re-reviewed.Unaddressed findings
Standards
Pair.panelis never written (speculative). Add the blind pairwise review page to the Console #1885's acceptance criteria require the reveal of "the panel's calls" and "people–panel agreement". Neither can be shown or tested without a read side for the panel's result. Grade each pair of Trials with a Grader panel, reported beside the Verdict #1882, which is open, produces it. The question of whether this contract shape suits Grade each pair of Trials with a Grader panel, reported beside the Verdict #1882 is filed as Align the people's blind-page rubric and panel result shape with the Grader panel (#1882) #1947.Spec
docs/research/eval-grader-panel.md:14, "The rubric's criteria"). Filed as Align the people's blind-page rubric and panel result shape with the Grader panel (#1882) #1947.tests/console/pairwise.rs.tests/console/pairwise.rs::the_blind_page_names_no_arm_and_shows_the_ticket_checklist_diffs_and_evidencepasses on it. A per-reader queue as the reader's entry point is Count the panel or people in the Verdict, with seeded samples for several readers #1886's "each reader's queue in the Console lists their sampled pairs".PanelCallsis fixed in format 10 ahead of Grade each pair of Trials with a Grader panel, reported beside the Verdict #1882. This is the same decision as P3/S2. Filed as Align the people's blind-page rubric and panel result shape with the Grader panel (#1882) #1947.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
This is a new page, new routes and new private files under each Experiment. Result format 10 is additive. Older retained pairs read with an empty
diffand nopanel.Blast Radius: Experiments
Only Experiment JSON consumers see the format bump. The Console's other pages are untouched apart from the new section on the Experiment page.
🤖 Generated with Claude Code
Built with claude 2.1.314 · opus · default effort