Repository navigation
Build and screen process Eval tasks from merged Tickets - #1926
Merged
Merged
Conversation
This was referenced Nov 10, 2026
JacobStephens2
added a commit
that referenced
this pull request
Nov 10, 2026
Preserve the process Grader documentation alongside process task proposals. Have proposals and preparation share the required process_grading table used by the Grader, retaining the proposal report format. Validation: Eval and process Trial tests, site and Console browser tests, cargo check, formatting, and all-target clippy pass. Full Rust validation stops at the Console idle IO regression already documented in #1926 (107775 bytes); its isolated rerun reproduces the failure.
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Process Eval tasks can now be drafted from merged Tickets and screened before preparation.
The process suite declares three Trials and dependencies on its five Factory skills, Built-in process sources and shared prompt, Harness, Model and Effort defaults.
An admin-scoped API twin proposes tasks only from known Launch directories.
Closes #1876
Evidence
Execution evidence
cargo test --test evals process_tasks::preparation -- --nocapturefailed both new cases withunknown field process_tests.After: the same command passed all three preparation cases, including inline-test rejection.
cargo test --test evals process_tasks::preparation_refuses_changed_inline_tests -- --nocapturefailed withassertion failed: !output.status.success().After: the same case passes and names the changed source file.
cargo test --test evals process_tasks::proposals -- --nocapturefailed with the existingevalsusage message.After:
cargo test --test evals process_tasks:: -- --nocapturepassed all four fixture cases, including proposal approval and preparation.python3 .thirdshift-review-2iXnN6/spec_executable_overlay.pyfailed withPermission denied; now exits 0.python3 .thirdshift-review-2iXnN6/spec_rebase_merge.pyfailed withpull request changes no source; now exits 0.python3 .thirdshift-review-2iXnN6/spec_squash_updated_base.pyreported four source lines instead of two; now exits 0 and checks the correct base.cargo test --bin thirdshift console::parity::every_cli_command_has_an_api_twin_or_reasoned_exclusioninitially failed becauseProposeProcesshad no API twin; it now passes. The new admin endpoint accepts known Launch directories.cargo test --test evals: 22 passed on the final commit. The Console admin cases and exact CLI/API parity test passed.cargo clippy --all-targets -- -D warningsandnpm run docs:check --prefix sitepassed.18641d83passed the full Rust suite, site tests and Console browser tests. Release build and smoke checks passed too.scripts/affected-tests origin/issue-1484completed 67 site and 169 Console browser tests successfully before its Rust phase found Python 3.9's missingtomllib. Selecting the installed Python 3.11 fixed the exact bug-origin regression and its full 18-test integration file.cargo testrun stopped after 682.07 s (no substantive compilation) atidle::unchanged_requests_reuse_retained_records_but_replacements_are_visible:unchanged request reread 107775 bytesversus a 48 KiB threshold. The exact isolated rerun fails locally too; CI passes this test on the same commit. A repeated Fleet browser case also timed out, then passed in isolation without concurrent test load. These are reported as validation discrepancies; the successful CI suite supplies full-suite validation.Tests cross the
thirdshift evalsCLI seam, using real temporary Git repositories and a fake GitHub executable at the external GitHub seam.The admin scope and known-directory guard are checked through HTTP.
Visual evidence
Documentation captures use matching expanded-page states at 1440×900 desktop and 390×844 mobile.
/ — desktop
/ — mobile
/how-it-works/ — desktop
/how-it-works/ — mobile
/architecture/ — desktop
/architecture/ — mobile
/docs/ — desktop
/docs/ — mobile
Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Review coverage
Independent Standards and Spec reviews compare against
issue-1484, pinned at8ad2733cfb7f8d3b9869a2c1b8f00b2eb224b447(the fetched origin branch). Each axis read all 30 changed files after one coverage follow-up. Unread changed files: none under either axis. Generated-output exclusions: none. Standards raised 1 finding; Spec raised 2; all were addressed. Session artifacts retain each report's final files-read list andsummary.jsonwith{"standards":1,"spec":2}in.thirdshift-review-2iXnN6/.Merge Danger
Door: two-way
Adds an optional manifest table and proposal command; existing review tasks retain their format. Process preparation executes explicitly selected test commands on the host with network access and a ten-minute deadline per command.
Blast Radius: Evals
Selector inference covers Rust integration tests and Python scripts. Drafts need Day-shift review and approval before preparation; unfamiliar layouts are reported as skipped.
Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh