Repository navigation
Pre-download trusted issue images for triage - #1922
Merged
Merged
Conversation
Keep image preparation in the shared Triage investigation path and retain both image-cache and unattended-Pass navigation entries. Validation: scripts/affected-tests main passed (3,951 Rust tests; 67 site checks). The Rust step took 2,958.41 seconds including compilation. Pickup model regressions, strict Clippy and formatting also passed.
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1892.
Markdown and HTML images on HTTPS GitHub attachment hosts are cached in
.thirdshift-issue-images/before the session starts, including--read-machine. Failed and oversized downloads warn and leave the investigation running.Evidence
Execution evidence
cargo test --bin thirdshift triage::images::tests::caches_markdown_and_html_images_once_and_lists_local_pathsfailed:
assertion left == right failed;left: [], expected the two trusted GitHub image URLs. Result:0 passed; 1 failed.After: the same command passed:
1 passed; 0 failed.UPDATE_PROMPTS=1 cargo test --bin thirdshift prompts_page: 14 passed; generated prompt/skill pages updated.npm run docs:check --prefix sitepassed.cargo fmt --checkandcargo clippy --all-targets -- -D warningspassed locally and in CI.NEXTEST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests origin/issue-1695passed all 67 site tests (183.38 s). Its slower local Rust run was stopped after successful CI on the identical head, reusing CI asdocs/testing.mddirects.f23fedaa,cargo nextest run:3941 tests run: 3941 passed (2 slow), 92 skipped. Execution took 1114.890 s; compilation was included in the step (1m 05s), for about 1181 s total. All applicable PR checks passed, including Console/site tests, static Linux builds and release smoke checks.Seams under test
Visual evidence
Manual, desktop 1440×900:
Factory skill, desktop 1440×900:
Manual, mobile 390×844:
Factory skill, mobile 390×844:
Review coverage
Independent
thirdshift-code-reviewStandards and Spec reviews againstissue-1695at6662e361. Standards raised one P3 finding, fixed inf23fedaaby keeping the image-inspection protocol in the Factory skill; Spec raised zero. Both axes read all 15 files in the final diff, including generated output. Changed files left unread: none. Generated-output exclusions: none.Unaddressed findings
Standards
None. S1 was addressed and rechecked by its reviewer.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert to remove the cache preparation; there is no persistent data migration.
Blast Radius: Triage
Existing-issue Triage preparation and its embedded skill; each image failure falls back to the issue text.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh