Repository navigation
Prototype Console/core split and measure rebuild times - #1920
Merged
Merged
Conversation
The branch added a report test that reads docs/research/console-core-split.md without registering that input, causing the repository documentation dependency guard to fail in CI. Select the prototype Python tests for report edits and retain the full Rust suite for prototype source edits. Add CLI regression coverage and document the selection. Validation: 55 Python tooling tests, 3 prototype tests, the release generator check, and scripts/affected-tests origin/main (3927 Rust tests passed).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the recorded four-vCPU host, Console edits rebuild 62.37% faster and
check 71.55% faster. Core rebuild and cold medians are essentially unchanged;
core checks cost another 1.19–4.67%. The report includes every sample,
method, host details, limitations and adoption costs. Production sources,
Cargo configuration, CI and ADR-0001 stay unchanged.
Closes #1889
Evidence
Execution evidence
python3 -m unittest discover -s prototypes/console-split -p 'test_*.py'failed with
AssertionError: None != 'https://github.com/JacobStephens2/thirdshift'.After: the same command passes all three tests. The split now preserves
CARGO_PKG_REPOSITORY, which the Eval replay importer uses to construct URLs.cargo build --lockedandcargo clippy --all-targets -- -D warningspasson the generated split.
cargo test --test evals replay_import_completes_trial_inputs_and_preserves_local_edits -- --exactand
cargo test --test packaging non_linux_compilation_reports_only_the_platform_error -- --exactboth pass. The export preserves package metadata and Linux guards.
cargo test --no-fail-faston the split passes: 3927 passed, 0 failed,91 ignored, 2352.408 s, including remaining compilation.
python3 prototypes/console-split/benchmark.py --samples 3 --jobs 4 --output /tmp/console-split-results-1889-v3passed: 48 measured samples, all 95 commands exited 0. Raw data is in
prototypes/console-split/results.json.report says 3930; top-level suites report 3927; the same command now passes and is retained intest_report.py.Prototype discovery passes 3 tests; existing Python tooling passes 41 tests.
/usr/bin/time -p scripts/affected-tests mainpassed the full Rust suite viacargo nextest run: 3927 passed, 91 skipped, 2203.52 s, including compilation.Test seams
prepare.pyCLI's exported Cargo workspace: dependency direction, parserownership, package metadata and byte-for-byte integration-test preservation.
prepare.pyCLI's refusal to overwrite a nonempty destination.Unaddressed findings
Standards
None. The one finding (duplicated archive export) was addressed.
Spec
None. The one finding (nested fixture results inflated the suite total) was addressed.
Security
None.
Security review outcome
No unaddressed introduced findings.
Review coverage
Both axes read all seven changed files, including every measurement record
and the new regression test. Generated-output exclusions: none. Unread changed
files: none. Review totals: Standards 1, Spec 1, both addressed.
Merge Danger
Door: two-way
The prototype and report can be removed without changing the production layout.
Blast Radius: prototype
The split runs only in exported temporary trees.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh