Skip to content

Support targeted in-place issue triage - #1911

Merged
JacobStephens2 merged 2 commits into
issue-1695from
issue-1891
Nov 9, 2026
Merged

JacobStephens2 merged 2 commits into
issue-1695from
issue-1891

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

thirdshift triage <Issue URL or number> [base <branch>] investigates and updates an existing issue in place. Report mode keeps its existing filing behavior.

triage(issue, base)
  check repository, open state and Trusted accounts
  reserve on origin → replace prior state with an in-progress Claim
  investigate selected Base branch with filtered .thirdshift-issue.md
  publish one comment → preserve category → apply state → close wontfix
  finish Claim on success, failure or Stop → release reservation

Readiness without permission becomes ready-for-human. Recommendation-only mode validates without reserving or writing to GitHub.

Closes #1891

Evidence

Execution evidence

  • Before: cargo test --test triage_issue issue_triage_updates_the_target_and_holds_readiness_for_the_day_shift -- --exact failed with thirdshift: unexpected argument after triage: 7 and left: Some(2), right: Some(0).
    After: The same command passed: 1 passed; 0 failed.
  • cargo test --test triage_issue --test triage_run: 7 issue-triage and 28 Report-mode tests passed. Coverage includes trust refusals, filtered comments, selected Base branch, reservation contention, publication outcomes, readiness permission, interruption and both Stop endings.
  • UPDATE_PROMPTS=1 cargo test --bin thirdshift prompts_page, then cargo test --bin thirdshift prompts_page: 14 passed each; generated prompt sources and output agree.
  • npm run docs --prefix site: regenerated the manual.
  • cargo fmt --check and cargo clippy --all-targets -- -D warnings: passed.
  • NEXTEST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests issue-1695: passed on b4b1ec2c. Site checks passed in 111.25s; the full Rust suite passed all 3,934 tests (92 skipped, 15 slow) in 3,388.45s including 27.82s compilation. Total selected-check wall time: 3,499.99s.
  • Before: cargo test --test command_surface help_is_a_compact_reference_with_a_link_to_the_details -- --exact failed with help should fit in a short reference, got 69 lines.
    After: The same command passed (1 passed; 0 failed, 0.18s) after combining the two triage usage lines, retaining the existing 68-line bound.
  • The initial scripts/affected-tests issue-1695 attempt passed site checks, then stopped on architect_run::base_fix_lets_the_dispatched_run_start_a_base_fix when systemd refused a transient scope: Unit thirdshift-session-523587-0-harness.scope was already loaded or has a fragment file. cargo test --test architect_run base_fix_lets_the_dispatched_run_start_a_base_fix -- --exact then passed in isolation (1 passed, 29.75s) and the final full suite passed with three test workers.

Test seams

  • The real thirdshift triage CLI against fake GitHub and Harness executables and a real bare origin: input, trust, publication, reservation, notification, failure and Stop.
  • Generated Session prompts through cargo test prompts_page; site behavior through its browser suite.

Visual evidence

Paired Before/After captures use the same pages and states at 1440×900 and 390×844. Before captures use the issue-1695 checkout.

Homepage: 1440×900

Before

After

Homepage: 390×844

Before

After

How it works: 1440×900

Before

After

How it works: 390×844

Before

After

User manual: 1440×900

Before

After

User manual: 390×844

Before

After

Session prompts: 1440×900

Before

After

Session prompts: 390×844

Before

After

Architecture: 1440×900

Before

After

Architecture: 390×844

Before

After

Review

  • Standards: 0 findings; all 19 changed files read.
  • Spec: 0 findings; all 19 changed files read.
  • Both axes also reviewed the final compact-help adjustment and retained 0 findings.
  • Unread changed files: none under either axis. Generated output was read directly; no exclusions.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

The change can be reverted without a data migration. Publishing an issue triage changes GitHub comments, labels and open state as described above.

Blast Radius: triage

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 6662e36 into issue-1695 Nov 9, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1891 branch November 9, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant