[JacobStephens2]

Summary

Put the Process engine's Ticket source and publication policy behind a factory/local seam. Factory execution keeps its existing behavior; the local adapter runs the Built-in Ticket run through Security review and stops before Delivery.

Process Step engine
└── Ticket source
    ├── Factory: GitHub, Claim, owned Worktree, pull request, Delivery
    └── Local: issue file, prepared repository, local origin, private Trial output

Closes #1873

Evidence

Execution evidence

• Seam: thirdshift --trial <request.json> on a local fixture repository and issue file; observe committed implementation, Security review, restored issue hand-over, Step/session artifacts and absence of GitHub publication.
• Seam: the Ticket source's Step admission interface rejects delivery and self-merge locally.
• Before: cargo test --test trial process::built_in_ticket_steps_run_locally_without_publication -- --exact against issue-1484, with the new regression: FAILED, invalid Trial request: unknown variant process, expected code-review or spec-review.
  After: the same command passes: 1 passed; 0 failed. It runs both Steps, restores the supplied issue file, commits locally, makes no gh calls or pull request, and stops before Delivery.
• cargo test --bin thirdshift processes::source::tests::local_source_refuses_publishing_steps -- --exact: 1 passed; 0 failed; both publishing Steps are refused with clear errors.
• cargo clippy --all-targets -- -D warnings: passed.
• cargo fmt --all -- --check and git diff --check: passed.
• UPDATE_PROMPTS=1 cargo test --bin thirdshift prompts_page: 14 passed; 0 failed; generated files are unchanged.
• CARGO_BUILD_JOBS=2 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests issue-1484: stopped at one existing Console I/O assertion after 1,662 unit tests and the preceding integration suites passed. The Console suite had 263 passed; 1 failed; 1 ignored.
• cargo test --test console idle::unchanged_requests_reuse_retained_records_but_replacements_are_visible -- --exact --nocapture: fails on this branch and on untouched issue-1484, both with unchanged request reread 107679 bytes (limit: 48 KiB). No Console source or test is changed here.
• All 81 remaining integration targets passed with cargo test --no-fail-fast, selected from Cargo metadata after the stopped console target (RUST_TEST_THREADS=6, Python 3.11). Wall time: 1595.32s, warm build cache, no compilation. This includes the unchanged Process, Ticket-run, Security-review and Spec-run tests and the new local Trial test.

Validation selects Python 3.11 through a temporary PATH shim. This host's default Python 3.9 lacks tomllib, required by the existing Bug-origin regression. The exact previously failing selector, cargo test --test bug_origins settlement::historical_review_and_reclosed_origin_regressions -- --exact, passes with Python 3.11.

Unaddressed findings

Standards

None. The one Standards finding (duplicated Trial result construction) was addressed by sharing result finishing across execution paths; the reviewer confirmed the fix.

Spec

None. The Spec review raised no findings.

Security

None.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both independent reviewers read all 12 changed files. No changed file was left unread, and no generated output was excluded. Reports and final files-read lists are retained in .thirdshift-review-71CgQm/standards.md and spec.md; summary.json records {"standards":1,"spec":0} before implementation decisions.

Merge Danger

Door: two-way

Blast Radius: Process

The factory adapter moves existing acquisition, issue checks, implementation, Security review and Delivery code. The local adapter has no publishing implementation.

Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh