Repository navigation
Skip unconsumed Markdown in affected test selection - #1900
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a repository reference guard and documents the selection rules. Current consumers require exceptions for the manual, glossary, experiment format, Console API ADR, and Go benchmark report.
site/tests/docs.test.cjsnow reads the glossary, so it receives site checks rather than the issue's proposed skip.Closes #1612
Evidence
Execution evidence
python3 -m unittest discover -s scripts -p test_affected_tests.py -k unread_markdownfailed for all six documentation paths:[['cargo', 'nextest', 'run']] != [].After: The same command passed; docs-only paths select no runner and print the reason.
scripts/affected-tests <base>through real Git and stand-in external runners; the repository's Markdown-reference audit through real source files and a deliberately added consumer.python3 -m unittest discover -s scripts -p test_affected_tests.py -k backtickfailed withAssertionError: AssertionError not raised.After: The same command passes (
Ran 1 test,OK). The reviewer’s exact reproducer, which first reads the doc with Node and then checks the guard, also exits 0. The regression test remains in the suite.python3 -m unittest discover -s scripts -p 'test_*.py': 49 tests passed in 26.876s with Python 3.12 on PATH for the runner and its subprocesses. The host's default Python 3.9 lackstomllib, so the release-tooling tests require this environment setup.scripts/affected-tests mainselected the full Rust suite for the selector edits (Cargo fallback because nextest is unavailable). First run stopped after 509.93s because a Python subprocess lackedtomllib;cargo test --test bug_origins settlement::historical_review_and_reclosed_origin_regressionspasses with Python 3.12 on PATH. Compilation was included (3m45s).scripts/affected-tests mainwith Python 3.12 on PATH stopped after 461.84s at the unchanged Console testidle::unchanged_requests_reuse_retained_records_but_replacements_are_visible:unchanged request reread 158035 bytes. Its isolated rerun,cargo test --test console idle::unchanged_requests_reuse_retained_records_but_replacements_are_visible, also fails (unchanged request reread 156691 bytes). No Rust sources or tests changed in this PR. Before that stop, all 1,661 Rust unit tests passed; remaining integration binaries were not run locally.8bf2109c; site, Console browser, and release checks have passed. The full local Rust suite is not green.Unaddressed findings
Review coverage: both reviewers read all three changed files. Unread changed files: none. Generated-output exclusions: none.
Review totals: Standards 0 findings; Spec 1 finding, fixed. Reports and final files-read lists are retained beside the Session trace.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: local
Changes local test selection. CI retains its existing checks on every PR.
Built with codex codex-cli 0.160.0 · gpt-6.1-sol · high