Repository navigation
docs: record Rust build-speed experiments and correct ring advice - #1869
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measurements come from #1868; they were not rerun for this PR. The original Method and timing table are preserved. Only the research note changes.
Closes #1868
Evidence
Execution evidence
rg -n '^## Experiments$' docs/research/rust-build-profile.md73:## Experiments; exit 0./usr/bin/time -p scripts/affected-tests main: first run failed after 731.85 s including compilation. Nextest ran 195/3,927 tests: 194 passed, one failed, 91 skipped; fail-fast left 3,732 unrun. The failure wasci::actions_jobs_survive_a_check_runs_403_and_red_ci_gets_a_repair, where starting the fake agent failed withUnit thirdshift-session-2547107-0-harness.scope was already loaded or has a fragment file.cargo test --test ci actions_jobs_survive_a_check_runs_403_and_red_ci_gets_a_repair -- --exact --nocapture: passed, 1 test, 5.62 s (plus 1.82 s build).1ae80a03: 3,927 tests passed, 91 skipped, 1,214.512 s test execution plus 70 s test compilation. Formatting, clippy and release-generator checks passed; site and Console CI passed too./usr/bin/time -p scripts/affected-tests mainran with the build cached and was stopped by session ID after CI passed on that exact head, reusing successful CI asdocs/testing.mddirects. No test failures were reported before the intentional interruption (exit 130).git diff --check main...HEAD: passed (exit 0).Review coverage
Independent
thirdshift-code-reviewreviewers compared againstmainand checked the final wording correction. Standards: 1 glossary finding, fixed and verified. Spec: 0 findings. Both reviewers read the only changed file,docs/research/rust-build-profile.md. Changed files left unread: none. Generated-output exclusions: none.Unaddressed findings
Standards
None. The glossary finding was addressed in
1ae80a03.Spec
None.
Security
None. The change is the research note only. It does not change the updater, TLS features, toolchain pin, or Cargo config.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The documentation edit can be reverted.
Blast Radius: documentation
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh