Repository navigation
Confirm Console config saves at the edited setting - #1867
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local and Fleet saves return to the edited setting with visible
role="status"feedback, with or without JavaScript. The manual and hand-written site pages describe the confirmation.Closes #1862
Evidence
Execution evidence
PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test console/tests/user-config.test.cjsFailed:
locator.waitFor: Timeout 5000ms exceededwaiting for the saved-setting status;1 test, 0 pass, 1 fail.After: Same command passed:
2 tests, 2 pass, 0 fail(33.62s), covering local/Fleet, JavaScript on/off, desktop/mobile, redaction and validation errors.PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test console/tests/user-config.test.cjs console/tests/fleet-control.test.cjs: 4 passed.cargo test --test console user_config: 2 passed, including API/CLI config parity.cargo test --test console fleet_config_uses_owners_admin_scope_and_refusals_survive_forwarding: 1 passed.npm run docs:check --prefix site: passed./usr/bin/time -p env PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright NEXTEST_TEST_THREADS=3 scripts/affected-tests origin/main, against GitHubmainat6c26e8d9: site 67 passed (94.11s), build passed (24.96s), Console 162 passed (158.76s). The fullcargo testattempt stopped after 322.63s, including compilation, because the host's default Python 3.9 lackstomllibin an unrelated bug-origin fixture.python3alias to the installed/usr/bin/python3.11,cargo test --test bug_origins settlement::historical_review_and_reclosed_origin_regressionspassed (1 test, 2.48s). A fullcargo testrerun passed the 1,661 unit tests and reached Console integration checks, where 263 passed and the existing idle-I/O assertion failed (350.71s total, cached compilation).cargo test --test console idle::unchanged_requests_reuse_retained_records_but_replacements_are_visible -- --exact --test-threads=1fails both at this PR head and in a temporary detached worktree at base6c26e8d9, identically:unchanged request reread 107679 bytesattests/console/idle.rs:43. The baseline worktree was removed afterward. No idle/cache code or test threshold is changed by this PR. The local full suite stops at that baseline failure; later Rust targets are left to CI. CI's Rust check is still running.Visual evidence
Fleet save:
spec.parallel = 10onorchestrate, after clicking Save.Desktop, 1440×900:
Mobile, 390×844:
Test seams
Review coverage
Independent Standards and Spec reviews against GitHub
mainat6c26e8d9: 0 findings on each axis. Both reviewers read all 11 changed files, including the generated manual hunk. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert restores the prior redirect behavior; no data migration.
Blast Radius: Console
Config-page save navigation and feedback. The config writer, CLI output and API JSON contract remain unchanged.
Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh