Skip to content

Confirm Console config saves at the edited setting - #1867

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1862
Nov 9, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1862

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Save <key> on the selected machine
  → validate and write through the existing config interface
  → redirect to /config?saved=<key>#config-<key> (Fleet keeps machine=<name>)
  → Saved <key> = <formatted, redacted value> on <machine>

Local and Fleet saves return to the edited setting with visible role="status" feedback, with or without JavaScript. The manual and hand-written site pages describe the confirmation.

Closes #1862

Evidence

Execution evidence

  • Before: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test console/tests/user-config.test.cjs
    Failed: locator.waitFor: Timeout 5000ms exceeded waiting for the saved-setting status; 1 test, 0 pass, 1 fail.
    After: Same command passed: 2 tests, 2 pass, 0 fail (33.62s), covering local/Fleet, JavaScript on/off, desktop/mobile, redaction and validation errors.
  • PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test console/tests/user-config.test.cjs console/tests/fleet-control.test.cjs: 4 passed.
  • cargo test --test console user_config: 2 passed, including API/CLI config parity.
  • cargo test --test console fleet_config_uses_owners_admin_scope_and_refusals_survive_forwarding: 1 passed.
  • npm run docs:check --prefix site: passed.
  • Final selection: /usr/bin/time -p env PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright NEXTEST_TEST_THREADS=3 scripts/affected-tests origin/main, against GitHub main at 6c26e8d9: site 67 passed (94.11s), build passed (24.96s), Console 162 passed (158.76s). The full cargo test attempt stopped after 322.63s, including compilation, because the host's default Python 3.9 lacks tomllib in an unrelated bug-origin fixture.
  • With a temporary python3 alias to the installed /usr/bin/python3.11, cargo test --test bug_origins settlement::historical_review_and_reclosed_origin_regressions passed (1 test, 2.48s). A full cargo test rerun passed the 1,661 unit tests and reached Console integration checks, where 263 passed and the existing idle-I/O assertion failed (350.71s total, cached compilation).
  • Baseline validation limitation: cargo test --test console idle::unchanged_requests_reuse_retained_records_but_replacements_are_visible -- --exact --test-threads=1 fails both at this PR head and in a temporary detached worktree at base 6c26e8d9, identically: unchanged request reread 107679 bytes at tests/console/idle.rs:43. The baseline worktree was removed afterward. No idle/cache code or test threshold is changed by this PR. The local full suite stops at that baseline failure; later Rust targets are left to CI. CI's Rust check is still running.

Visual evidence

Fleet save: spec.parallel = 10 on orchestrate, after clicking Save.

Desktop, 1440×900:

Before
After

Mobile, 390×844:

Before
After

Test seams

  • Console HTTP requests: config save redirects, status HTML, validation and remote errors; API/CLI parity.
  • Console browser forms: saving local and Fleet settings with and without JavaScript, anchoring and visible redacted feedback on desktop and mobile.

Review coverage

Independent Standards and Spec reviews against GitHub main at 6c26e8d9: 0 findings on each axis. Both reviewers read all 11 changed files, including the generated manual hunk. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert restores the prior redirect behavior; no data migration.

Blast Radius: Console

Config-page save navigation and feedback. The config writer, CLI output and API JSON contract remain unchanged.

Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit b89d943 into main Nov 9, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1862 branch November 9, 2026 19:58
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make it more clear to user in UI of /config?machine=orchestrate what happened after they clicked a save button to update the config

1 participant