Repository navigation
Link Console machine heading to Overview - #1864
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking the serving machine's name returns to the full Overview Inbox, clearing page, section and machine filters. The link keeps the heading colour and gains an underline on hover or keyboard focus. Update the user manual and the hand-written site descriptions.
Keep the Experiment title test independent of the heading's HTML by reading the serving hostname from the Console identity endpoint.
Closes #1863
Evidence
Execution evidence
node --test --test-name-pattern='the header machine name' console/tests/inbox.test.cjsfailed in all four desktop/mobile and JavaScript/no-JavaScript cases:locator.getAttribute: Timeout 5000ms exceeded, waiting for the header heading's link.After: The same command passed:
# tests 5,# pass 5,# fail 0.node --test --test-name-pattern='the header machine name|the header link|editor saves' console/tests/inbox.test.cjs console/tests/custom-themes.test.cjspassed:# tests 7,# pass 7,# fail 0. Covers filter clearing, secondary pages, Tab/Enter, built-in Theme modes and a custom Theme.npm run docs:check --prefix sitepassed.experiments::experiment_pages_and_the_cli_show_the_name_or_its_defaulttest initially failed because it used the heading's inner HTML as the hostname. After switching to the identity endpoint,cargo test --test console experiments::experiment_pages_and_the_cli_show_the_name_or_its_default -- --exactpassed:1 passed; 0 failed.RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests main: site 67/67 passed (64.82 s),cargo build --lockedpassed, Console browser tests 166/166 passed (166.53 s). Local Rust unit tests passed 1,661 with 3 ignored, and Console HTTP tests passed 264 with 1 ignored. Stopped the duplicate local Rust run after successful CI covered the exact final head, followingdocs/testing.md's CI-reuse rule.e2059348passed: formatting, strict Clippy, release-generator checks, site and Console browser tests, and the completecargo nextest run: 3,927 passed, 91 skipped, 977.126 s test execution. Release artifact builds also passed.Test seams: the rendered Console in Chromium, observing link destinations, navigation, keyboard focus and computed Theme styles; Console HTTP responses for Experiment names and titles, using the public identity endpoint for the hostname.
Visual evidence
Done section, Focus light Theme, header at rest. The link preserves the heading's appearance.
Desktop, 1440 × 900:
Mobile, 390 × 844:
Review coverage
Independent Standards and Spec reviews against
main, including coverage follow-ups for the Experiment title test: 0 findings on each axis. Both reviewers read all ten changed files, including the generated manual hunk. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the header link and its CSS to restore the previous behavior.
Blast Radius: Console
Shared-header navigation and heading link appearance across Themes.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh