Skip to content

Link Console machine heading to Overview - #1864

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1863
Nov 9, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1863

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

-<h1>{{ page.hostname }}</h1>
+<h1><a href="/?section=overview">{{ page.hostname }}</a></h1>

Clicking the serving machine's name returns to the full Overview Inbox, clearing page, section and machine filters. The link keeps the heading colour and gains an underline on hover or keyboard focus. Update the user manual and the hand-written site descriptions.

Keep the Experiment title test independent of the heading's HTML by reading the serving hostname from the Console identity endpoint.

Closes #1863

Evidence

Execution evidence

  • Before: node --test --test-name-pattern='the header machine name' console/tests/inbox.test.cjs failed in all four desktop/mobile and JavaScript/no-JavaScript cases: locator.getAttribute: Timeout 5000ms exceeded, waiting for the header heading's link.
    After: The same command passed: # tests 5, # pass 5, # fail 0.
  • node --test --test-name-pattern='the header machine name|the header link|editor saves' console/tests/inbox.test.cjs console/tests/custom-themes.test.cjs passed: # tests 7, # pass 7, # fail 0. Covers filter clearing, secondary pages, Tab/Enter, built-in Theme modes and a custom Theme.
  • npm run docs:check --prefix site passed.
  • The existing experiments::experiment_pages_and_the_cli_show_the_name_or_its_default test initially failed because it used the heading's inner HTML as the hostname. After switching to the identity endpoint, cargo test --test console experiments::experiment_pages_and_the_cli_show_the_name_or_its_default -- --exact passed: 1 passed; 0 failed.
  • Final local selection, RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests main: site 67/67 passed (64.82 s), cargo build --locked passed, Console browser tests 166/166 passed (166.53 s). Local Rust unit tests passed 1,661 with 3 ignored, and Console HTTP tests passed 264 with 1 ignored. Stopped the duplicate local Rust run after successful CI covered the exact final head, following docs/testing.md's CI-reuse rule.
  • CI for e2059348 passed: formatting, strict Clippy, release-generator checks, site and Console browser tests, and the complete cargo nextest run: 3,927 passed, 91 skipped, 977.126 s test execution. Release artifact builds also passed.

Test seams: the rendered Console in Chromium, observing link destinations, navigation, keyboard focus and computed Theme styles; Console HTTP responses for Experiment names and titles, using the public identity endpoint for the hostname.

Visual evidence

Done section, Focus light Theme, header at rest. The link preserves the heading's appearance.

Desktop, 1440 × 900:

Before
After

Mobile, 390 × 844:

Before
After

Review coverage

Independent Standards and Spec reviews against main, including coverage follow-ups for the Experiment title test: 0 findings on each axis. Both reviewers read all ten changed files, including the generated manual hunk. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the header link and its CSS to restore the previous behavior.

Blast Radius: Console

Shared-header navigation and heading link appearance across Themes.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit b517522 into main Nov 9, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1863 branch November 9, 2026 19:25
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console: link the header machine name to /?section=overview

1 participant