Repository navigation
Prototype: TypeScript Pickup and bounded BFS verification - #1845
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Pickup and an independent bounded BFS checker to the isolated TypeScript prototype.
Busy and stale selections move on to the next candidate. Uncertain origin results fail closed with recovery evidence. The model exhausts three-host interleavings, crashes and Day shift recovery; both unguarded variants must produce shortest counterexample traces.
This Ticket-only prototype applies the Claim before session dispatch. Its model verifies that ordering; it does not prove the Rust protocol's known failing pre-Claim dispatch property. Specs, Continuation and Delivery remain outside this slice.
Closes #1838
Evidence
Execution evidence
PATH=/home/jstephens/.bun/bin:$PATH bun test --cwd prototypes/typescript -t 'Pickup selects'failed: expected empty stderr, receivedInvalid URL(0 pass, 1 fail).After: the same command passed (1 pass, 0 fail); it verifies lowest-numbered selection, a parentless empty-tree reservation during the session, atomic Claim application and reservation release.
PATH=/home/jstephens/.bun/bin:$PATH bun test ./.thirdshift-review-RdXbAv/spec-case.test.tsfailed (0 pass, 1 fail), returning a Ready issue with an activeIn-ProgressClaim.After: the exact same command passed (1 pass, 0 fail). Its regression is retained in
prototypes/typescript/tests/ready.test.ts; CLI tests also cover differently cased history and preserving unrelated label spelling.PATH=/home/jstephens/.bun/bin:$PATH scripts/affected-tests origin/issue-1831passed TypeScript typechecking and all 36 Bun tests. CLI cases include contention, stale re-reads, trust/history rejection, paginated edits, remote errors, changed-token release and interruption cleanup.Test seams: standalone CLI against temporary origin repositories and fake
gh/Harness executables; independent request-level BFS; the exportedReadyIssues.readseam with a fake command adapter for the retained review regression.Review
Fixed point: remote
issue-1831, pinned to1aff914c3afdb32a690db2556759b5b07aed5536. The local branch is checked out in another worktree and stale, so validation uses its fetched remote tracking ref..thirdshift-review-RdXbAv/standards.md,spec.md, andsummary.json({"standards":2,"spec":1}).Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The changes are confined to the prototype. Running Pickup creates origin reservation refs and changes issue labels; interrupted or uncertain ownership can require the documented token-leased human recovery.
Blast Radius: Prototype
The production Rust executable and website are unchanged. The existing prototype Claim also uses atomic label PUTs and case-insensitive comparisons.
Built with codex codex-cli 0.160.0 · gpt-6.1-sol · high
CI notes
git diff origin/issue-1831...HEAD -- .github/workflows site docs/guide.mdis empty (base1aff914c). Localnpm test --prefix sitepassed all 67 tests and docs generation checks;PATH=/home/jstephens/.bun/bin:$PATH scripts/affected-tests origin/issue-1831passed typechecking and all 36 Bun tests.