Skip to content

Fleet: remote Stop, Dismissal and Undo - #1829

Merged
JacobStephens2 merged 2 commits into
issue-1142from
issue-1765
Nov 6, 2026
Merged

JacobStephens2 merged 2 commits into
issue-1142from
issue-1765

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Remote rows offer confirmed Stop, Dismiss and Undo using each person's effective scopes on the owning machine. CLI Stop and Dismiss accept --machine; the owner authorizes, acts and keeps the Activity log.

Console + signed-in person ─┐
CLI + token holder ────────┴─> owning /api/v1
                               ├─ Stop its Command
                               ├─ Dismiss / Undo its row
                               └─ record its Activity log

Closes #1765

Evidence

Execution evidence

  • Before: cargo test --test console fleet::cli_remote_dismiss_and_undo_use_only_the_owning_machine -- --exact failed with usage: thirdshift dismiss <command> [--undo] [--json].
    After: the same command passed; the retained test also checks remote text output and no caller-side Activity log or Console log changes.
  • Before: node --test --test-name-pattern='Fleet Inbox polls' console/tests/fleet.test.cjs failed with locator.waitFor: Timeout 5000ms exceeded waiting for the remote Dismiss button.
    After: the same command passed, including remote Dismiss, row departure, Undo and row return.
  • cargo test --test console fleet: 15 passed, covering two-Console Stop and Dismiss/Undo, person/token scope intersections, simultaneous viewers, unknown-person and Other-account refusals, attribution and owner-only writes.
  • CI on 04843aab: 3,862 Rust tests passed, 91 skipped; Rust execution took 1,063.381s. Formatting, clippy --all-targets, site tests and Console browser tests also passed. Both release artifact builds passed.
  • NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests issue-1142: 62 site tests and 143 Console browser tests passed. The local Rust run recorded 938 passes before stopping on the existing OTLP timing assertion (baseline 5.0687s; stalled 7.7411s); 1,981.13s for the Rust command including compilation, 2,424.02s for the selected checks overall. The exact isolated test passed, and RUST_TEST_THREADS=1 cargo test --test otlp_endpoint passed all 4 tests. A remaining-binary run recorded 961 further passes before being intentionally stopped once the complete CI suite passed on the same head; its 4 interrupted tests are cancellations, not additional failures.
  • cargo clippy --bin thirdshift -- -D warnings and npm run docs:check --prefix site: passed.
  • An initial default-thread Dismissal run hit the existing live-silence timing check (row is in Working). RUST_TEST_THREADS=3 cargo test --test stop --test dismiss passed: 35 tests, 2 fixture entry points ignored. The full Rust run also uses three threads as documented in docs/testing.md.

Test seams:

  • Binary CLI: stop / dismiss --machine, including Undo, JSON, text and refusals.
  • Two real Consoles over HTTP: signed-in actions, effective scopes, owning-machine attribution and persistence.
  • Real Console in Chromium: remote controls, Dismiss/Undo and responsive layout; HTTP coverage checks Stop confirmation and real Command cleanup.

Visual evidence

Desktop, 1440×900, Fleet Inbox with an authorized remote Needs you row:

Before
After

Mobile, 390×844, same state:

Before
After

Review

Fixed point: issue-1142 (0be6e877). Standards: 2 findings, both addressed by sharing Ready-for-review presentation and local/remote CLI result formatters. Spec: 0 findings. Both axes read every changed file, including generated manual changes; no generated exclusions or unread changed files remain. Reports and finding counts are saved in .thirdshift-review-64RuZM/ in the session worktree.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

No storage migration. Remote requests retain the owning machine's authorization and process-identity checks.

Blast Radius: Fleet

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 5af6501 into issue-1142 Nov 6, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1765 branch November 6, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant