Repository navigation
Fleet: remote Stop, Dismissal and Undo - #1829
Merged
Merged
Conversation
This was referenced Nov 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remote rows offer confirmed Stop, Dismiss and Undo using each person's effective scopes on the owning machine. CLI Stop and Dismiss accept
--machine; the owner authorizes, acts and keeps the Activity log.Closes #1765
Evidence
Execution evidence
cargo test --test console fleet::cli_remote_dismiss_and_undo_use_only_the_owning_machine -- --exactfailed withusage: thirdshift dismiss <command> [--undo] [--json].After: the same command passed; the retained test also checks remote text output and no caller-side Activity log or Console log changes.
node --test --test-name-pattern='Fleet Inbox polls' console/tests/fleet.test.cjsfailed withlocator.waitFor: Timeout 5000ms exceededwaiting for the remote Dismiss button.After: the same command passed, including remote Dismiss, row departure, Undo and row return.
cargo test --test console fleet: 15 passed, covering two-Console Stop and Dismiss/Undo, person/token scope intersections, simultaneous viewers, unknown-person and Other-account refusals, attribution and owner-only writes.04843aab: 3,862 Rust tests passed, 91 skipped; Rust execution took 1,063.381s. Formatting,clippy --all-targets, site tests and Console browser tests also passed. Both release artifact builds passed.NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests issue-1142: 62 site tests and 143 Console browser tests passed. The local Rust run recorded 938 passes before stopping on the existing OTLP timing assertion (baseline 5.0687s; stalled 7.7411s); 1,981.13s for the Rust command including compilation, 2,424.02s for the selected checks overall. The exact isolated test passed, andRUST_TEST_THREADS=1 cargo test --test otlp_endpointpassed all 4 tests. A remaining-binary run recorded 961 further passes before being intentionally stopped once the complete CI suite passed on the same head; its 4 interrupted tests are cancellations, not additional failures.cargo clippy --bin thirdshift -- -D warningsandnpm run docs:check --prefix site: passed.row is in Working).RUST_TEST_THREADS=3 cargo test --test stop --test dismisspassed: 35 tests, 2 fixture entry points ignored. The full Rust run also uses three threads as documented indocs/testing.md.Test seams:
stop/dismiss --machine, including Undo, JSON, text and refusals.Visual evidence
Desktop, 1440×900, Fleet Inbox with an authorized remote Needs you row:
Mobile, 390×844, same state:
Review
Fixed point:
issue-1142(0be6e877). Standards: 2 findings, both addressed by sharing Ready-for-review presentation and local/remote CLI result formatters. Spec: 0 findings. Both axes read every changed file, including generated manual changes; no generated exclusions or unread changed files remain. Reports and finding counts are saved in.thirdshift-review-64RuZM/in the session worktree.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
No storage migration. Remote requests retain the owning machine's authorization and process-identity checks.
Blast Radius: Fleet
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh