Skip to content

Open remote Fleet Command details in the caller Console - #1828

Merged
JacobStephens2 merged 4 commits into
issue-1142from
issue-1764
Nov 6, 2026
Merged

JacobStephens2 merged 4 commits into
issue-1142from
issue-1764

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fleet row → caller's Peek / Waterfall / log templates
                       ↓ scoped token + signed-in person
                 owning Console /api/v1
show / logs --machine → owning machine's JSON

Remote Commands open in place with child Ticket runs, stages, Waterfall, Command logs and Session traces. Each view keeps the owning-machine links. Security refusals name the required scope and machine. Reads stay request-local; previews use a bounded 4 KiB tail through the existing log endpoint and its logs --tail --json twin.

Test seams: two real Console binaries over HTTP and their public CLI, with isolated fixture homes; browser interactions through the caller at 1440×900 and 390×844, including checks for remote content on the caller's disk.

Closes #1764

Evidence

Execution evidence

  • Before: cargo test --test console remote_details::remote_command_details_render_locally_and_fetch_fresh_without_writing_content -- --exact
    assertion `left == right` failed: remote Command must open on the caller
      left: 404
     right: 200
    test result: FAILED. 0 passed; 1 failed
    
    After: the same command passes: test result: ok. 1 passed; 0 failed.
  • Both reviewers' behavior reproductions were executed before deciding. Retained regressions cover the preview byte budget, exact child selectors and preserving readable text after UTF-8 normalization.
  • cargo test --test console remote_details -- --test-threads=3: 6 passed. node --test console/tests/remote-regressions.test.cjs: 3 passed.
  • scripts/affected-tests issue-1142: all 62 site checks and 147 Console browser tests passed locally. Its duplicate local Rust phase was stopped after CI passed the full suite on the exact published head, reusing CI as docs/testing.md directs.
  • Full Rust CI result: 3,863 passed, 91 skipped, 1,146.016 seconds of test execution, head 838dd26a2f9e5030987af6fe05862b8afef4cb73.
  • cargo clippy --all-targets --locked -- -D warnings, cargo fmt -- --check, and generated-doc checks passed.
  • Console CI rerun passed after retrying a Chromium-installation cancellation. All CI checks now pass; the local Console suite also passed all 147 tests.

Visual evidence

Remote Command details, 1440×900:

Before
After

Remote Command details, 390×844:

Before
After

Review coverage

Reviewed with thirdshift-code-review against pinned issue-1142 (0be6e877), including its preceding Fleet Inbox commits. Standards raised 2 findings; Spec raised 2. All are addressed. Both axes read all 48 changed files; no generated-output exclusions or unread changed files.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert restores the previous readers; no storage migration.

Blast Radius: Console

Shared local and remote detail readers, their CLI parsing and the Fleet Inbox's exact record selectors.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Preserve in-place Fleet details alongside remote Stop, Dismiss and Undo. Share the viewer identity helper and regenerate the manual from its merged source.
@JacobStephens2
JacobStephens2 merged commit 6fd869a into issue-1142 Nov 6, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1764 branch November 6, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant