Skip to content

Keep repositories visible on Inbox rows without an issue - #1823

Merged
JacobStephens2 merged 6 commits into
mainfrom
issue-1821
Nov 10, 2026
Merged

JacobStephens2 merged 6 commits into
mainfrom
issue-1821

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Inbox rows without an issue or pull request show their repository above the Command name. Security runs, Triage runs and Custom processes can be identified without opening Command details. Long repositories wrap on desktop and phone.

- secure-20261106T070021-0500 on …
+ JacobStephens2/quadrille
+ secure-20261106T070021-0500

Closes #1821

Evidence

Execution evidence

Test seam: the rendered Console Inbox, served over HTTP from fixture Command records and read in Chromium.

  • Before: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test --test-name-pattern='Inbox shows the repository' console/tests/inbox.test.cjs failed all 12 viewport/Command/repository cases: repository must be readable in the row. In the example Security row, the subject ended at x=569 but its repository extended to x=730.
    After: the same command passed: tests 13, pass 13, fail 0 (12 cases plus the parent test).
  • Review regression: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test --test-name-pattern='Inbox shows a full Command name' console/tests/inbox.test.cjs failed before with Without JavaScript the full Command name must be readable: {"width":341,"fullWidth":525} and passed after: tests 1, pass 1, fail 0. The reviewer's original standalone command also failed before and passed after (width:341, fullWidth:341, whiteSpace:"normal", overflow:"visible"). The test is retained in console/tests/inbox.test.cjs.
  • Targeted Inbox validation: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright node --test --test-name-pattern='Inbox shows|Inbox keeps issue numbers' console/tests/inbox.test.cjs — 19 passed, 0 failed.
  • Local selection: PLAYWRIGHT_BROWSERS_PATH=/home/jstephens/.cache/ms-playwright scripts/affected-tests origin/main — build passed; all 153 Console browser tests passed in 132.03s. The Rust run (367.77s, including 148s compilation) passed 1,654 unit tests, then stopped at bug_origins because the host's default Python 3.9 lacks tomllib. Re-running that exact failing test with Python 3.11 on a private PATH passed: PATH=/tmp/issue-1821-tools.etObqR:$PATH cargo test --test bug_origins settlement::historical_review_and_reclosed_origin_regressions (1 passed, 0 failed). Full Rust CI for the published head is in progress.
  • origin/main is the fetched main tip, a7d76bbb; the local main is stale and checked out elsewhere. Both independent reviews used an isolated checkout with main pinned to that fetched tip and git diff main...HEAD.

Visual evidence

1440×900 desktop, Needs you with Command details closed:

Before desktop
After desktop

390×844 phone, the same folder and state:

Before mobile
After mobile

Review coverage

Standards raised 2 findings: 1 fixed and 1 declined below. Spec raised 0. Each reviewer read all 4 changed files: console/README.md, console/tests/inbox.test.cjs, src/console/assets/console.css, src/console/row.html. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

Standards

  • S2 — possible Primitive Obsession, src/console/row.html:2: declined the suggestion to introduce structured subject fields solely for this layout. The sole unlinked-subject formatter in src/logs/status/inbox.rs:394–418 guarantees <Command> on <repository>; splitting its final on also handles Command labels containing that text. The template already follows this presentation-splitting pattern for linked # subjects. This is a documented implementation tradeoff, with no demonstrated behavioral failure or decision deferred to the Spec or Day shift.

Spec

None.

Merge Danger

Door: two-way

Reverting restores the previous row rendering; no stored records change.

Blast Radius: Console

Changes the repository and Command-name layout on Inbox and History rows without a linked issue or pull request. Linked subjects retain their existing rendering.

Built with claude 2.1.322 · claude-opus-5-5 · medium

# Conflicts:
#	src/console/assets/console.css
#	src/console/row.html
Rows without an issue now show the repository before the Command (#1821),
so the subject's text no longer reads '<Command> on <repository>'. The
subject's title attribute still does.
@JacobStephens2 JacobStephens2 removed the in-progress A Claim: thirdshift has taken this issue label Nov 10, 2026
@JacobStephens2
JacobStephens2 merged commit 02c9654 into main Nov 10, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1821 branch November 10, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure that thirdshift console inbox makes it clear in rows which repo the work is on without having to open command details pane

1 participant