Skip to content

Add Inbox pull-request hand-off and Console Copy fix command - #1806

Merged
JacobStephens2 merged 4 commits into
issue-1784from
issue-1797
Nov 6, 2026
Merged

JacobStephens2 merged 4 commits into
issue-1784from
issue-1797

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ready for review / Needs you
  → later Command on the same issue or pull request
  → taken up by a later Command started at <time>

Ready rows with CI red or Merge conflict offer Copy fix command in the Inbox and Command details. Documents the Fix run hand-off across the manual and site.

Fix runs also capture their trust cutoff before Worktree acquisition, so slow acquisition cannot hide recent untrusted edits to linked issues.

Closes #1797

Test seams

  • thirdshift status text and JSON over retained Command records and GitHub facts.
  • Console Inbox and Command details over HTTP, including browser clipboard interaction.
  • Fix run CLI over real Git and fake GitHub/Harness services, with a child-only clock shift during Worktree acquisition.

Evidence

Execution evidence

  • Before: cargo test --test status later_commands_take_up_waiting_rows_on_the_same_pull_request -- --exact failed with left: String("ready for review"), right: "resolved".
    After: the same command passed: 1 passed; 0 failed.

  • Before: node --test --test-name-pattern='Copy fix command' console/tests/inbox.test.cjs failed with 1440:ready for review:red:mergeable / 0 !== 1.
    After: the same command passed: 1 passed; 0 failed; it checks Inbox and Peek clipboard values at 1440px and 390px.

  • Before: cargo test --test review_fix_trust_cutoff -- --nocapture failed with an edit inside the Command's trust window reached a Repair.
    After: the same command passed: 1 passed; 0 failed; 1 ignored (fixture guardian). The Fix run now captures its trust cutoff before Worktree acquisition.

  • Before: cargo test --test console ready_dispatches_leave_ready_for_review_and_are_shown_at_most_once -- --exact --nocapture failed because the unrelated issue 9 row appeared in Resolved.
    After: the same command passed: 1 passed; 0 failed. The fixture now gives unrelated issues distinct PR URLs; the assertions are unchanged.

scripts/affected-tests issue-1784 passed all 62 site tests, all 138 Console browser tests, 1,641 Rust unit tests (3 ignored), and the earlier integration suites. Experiments reported 121 passed and five marker waits caused by the allocated terminal's interactive cost confirmation. All five cases passed with stdin closed (5 passed; 0 failed), and all 69 remaining Rust integration targets passed headlessly with cargo test --no-fail-fast (1,294.87 seconds, compilation cached). Every selected test passed across these runs.

Visual evidence

Inbox, 1440×900

Before
After

Command details, 1440×900

Before
After

Inbox, 390×844

Before
After

Command details, 390×844

Before
After

Merge Danger

Door: two-way

Blast Radius: Commands

Unaddressed findings

Standards

None. S1 reproduced and was fixed with its regression retained.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both axes read 54 of 55 changed files against issue-1784 pinned at 31e2e33d, including the prerequisite Fix run changes. Unread by Standards and Spec: tests/console.rs, whose unrelated-issue fixture was corrected after the single coverage follow-up; the focused test passes with its assertions unchanged. No generated-output exclusions. Standards raised 1 finding (fixed); Spec raised 0. Reports are retained with the Session trace.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Keep unattended Fix Pass selection alongside the pre-acquisition trust cutoff, and retain both Fix Pass and Inbox hand-off architecture documentation. Regenerate the user manual from the merged guide.
@JacobStephens2
JacobStephens2 merged commit b867250 into issue-1784 Nov 6, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1797 branch November 6, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant