Repository navigation
Comment on open issues covering a Triage Report - #1720
Merged
Merged
Conversation
Preserve existing-issue comments from #1709 alongside the forwardable questionnaires from #1710. Regenerate the manual and prompt reference from their merged sources, and cover comments alongside mixed questionnaire outcomes. Validation: cargo check --locked, cargo fmt --check, prompt generation/verification, 61 site checks, 18 Triage integration tests, 47 notification tests and 16 skill tests passed. The unit suite passed 1619 tests in 268.69s with three unchanged stalled Harness/session fixtures excluded. The required affected-tests run passed its site checks but was stopped at those three fixtures without an assertion failure.
Preserve comments on covering issues alongside opt-in machine-reading confinement and forwardable questionnaires. Regenerate the manual and prompt reference from their merged sources, and extend the real Bubblewrap regression to verify comment publication, unchanged labels and notification links. Validation: cargo check --all-targets, cargo fmt --check, 13 prompt-generation tests, 21 Triage integration tests and 2 retained-home tests passed. The required affected-tests run follows this commit.
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Factory skill, generated prompt reference, user manual and hand-written site pages.
Closes #1709
Evidence
cargo test --test triage_run triage_comments_on_a_covering_issue_without_filing_or_changing_labelsfailed:unknown field comments.After: The same test passes, observing the quoted Report, new evidence, unchanged issue labels, no duplicate issue and the notification link.
cargo check --bin thirdshift,cargo fmt --check, prompt regeneration (13 tests), and the manual generation check pass.NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests origin/issue-1323passed: all 61 site tests and the full Rust suite, including 15 Triage integration tests (one intentional fixture ignore). The selector used its documentedcargo testfallback because nextest is unavailable locally. Rust wall time: 3047.77s, including 1m 49s compilation; total selector wall time: 3190.28s. Local test concurrency was three.4e0624a1df1a28920542cdae2a5547cd65e2fa2b, including its main test, site, Console and artifact build jobs.Test seams
thirdshift triageCLI with the existing fake Harness and GitHub adapter: observe published issue comments, preserved labels, recommendation JSON and Run notifications.--recommend-only: observe the named existing issue and proposed comment without GitHub writes.Review coverage
Review fixed point:
issue-1323atce7a996688be0ad35e28fcc812a60ad98a8c26b1, fetched fromorigin/issue-1323; the local branch ref was stale. Both independent axes review the complete diff from that commit.Standards: 0 findings. Spec: 0 findings. Each reviewer read all 14 changed files, including generated-output hunks. Unread changed files: none. Generated-output exclusions: none. Reports and each axis's complete files-read list are retained in
.thirdshift-review-QK5ik8/standards.mdand.thirdshift-review-QK5ik8/spec.md, with counts insummary.jsonbeside them.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The code can be reverted; posted GitHub comments can be deleted.
Blast Radius: Triage
Triage publication adds comments on covering open issues in the same repository. Existing issue labels are preserved.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh