Skip to content

Comment on open issues covering a Triage Report - #1720

Merged
JacobStephens2 merged 3 commits into
issue-1323from
issue-1709
Nov 4, 2026
Merged

JacobStephens2 merged 3 commits into
issue-1323from
issue-1709

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Report → investigate and search the repository's open issues
  covered   → comment with Report + new evidence; keep existing labels
  uncovered → file a shaped issue
  --recommend-only → return proposals, including any existing issue URL
stdout + Run notification → every filed or commented-on issue URL

Updates the Factory skill, generated prompt reference, user manual and hand-written site pages.

Closes #1709

Evidence

  • Before: cargo test --test triage_run triage_comments_on_a_covering_issue_without_filing_or_changing_labels failed: unknown field comments.
    After: The same test passes, observing the quoted Report, new evidence, unchanged issue labels, no duplicate issue and the notification link.
  • Recommend-only, invalid/closed/out-of-repository targets, and partial comment failure regressions pass through the real CLI and existing external-tool fakes.
  • cargo check --bin thirdshift, cargo fmt --check, prompt regeneration (13 tests), and the manual generation check pass.
  • NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests origin/issue-1323 passed: all 61 site tests and the full Rust suite, including 15 Triage integration tests (one intentional fixture ignore). The selector used its documented cargo test fallback because nextest is unavailable locally. Rust wall time: 3047.77s, including 1m 49s compilation; total selector wall time: 3190.28s. Local test concurrency was three.
  • CI passed for head 4e0624a1df1a28920542cdae2a5547cd65e2fa2b, including its main test, site, Console and artifact build jobs.

Test seams

  • The thirdshift triage CLI with the existing fake Harness and GitHub adapter: observe published issue comments, preserved labels, recommendation JSON and Run notifications.
  • The same CLI under --recommend-only: observe the named existing issue and proposed comment without GitHub writes.

Review coverage

Review fixed point: issue-1323 at ce7a996688be0ad35e28fcc812a60ad98a8c26b1, fetched from origin/issue-1323; the local branch ref was stale. Both independent axes review the complete diff from that commit.

Standards: 0 findings. Spec: 0 findings. Each reviewer read all 14 changed files, including generated-output hunks. Unread changed files: none. Generated-output exclusions: none. Reports and each axis's complete files-read list are retained in .thirdshift-review-QK5ik8/standards.md and .thirdshift-review-QK5ik8/spec.md, with counts in summary.json beside them.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

The code can be reverted; posted GitHub comments can be deleted.

Blast Radius: Triage

Triage publication adds comments on covering open issues in the same repository. Existing issue labels are preserved.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Preserve existing-issue comments from #1709 alongside the forwardable questionnaires from #1710. Regenerate the manual and prompt reference from their merged sources, and cover comments alongside mixed questionnaire outcomes.

Validation: cargo check --locked, cargo fmt --check, prompt generation/verification, 61 site checks, 18 Triage integration tests, 47 notification tests and 16 skill tests passed. The unit suite passed 1619 tests in 268.69s with three unchanged stalled Harness/session fixtures excluded. The required affected-tests run passed its site checks but was stopped at those three fixtures without an assertion failure.
Preserve comments on covering issues alongside opt-in machine-reading confinement and forwardable questionnaires. Regenerate the manual and prompt reference from their merged sources, and extend the real Bubblewrap regression to verify comment publication, unchanged labels and notification links.

Validation: cargo check --all-targets, cargo fmt --check, 13 prompt-generation tests, 21 Triage integration tests and 2 retained-home tests passed. The required affected-tests run follows this commit.
@JacobStephens2
JacobStephens2 merged commit 1217d2d into issue-1323 Nov 4, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1709 branch November 4, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant