Repository navigation
File triaged issues by default - #1716
Merged
Merged
Conversation
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thirdshift adds the AI-generated disclaimer and collapsed verbatim Report with its source. Agent readiness requires
--allow-ready-for-agentor[triage] allow_ready_for_agent = true; confirmation needing credentials or production access goes toready-for-humanwith its reason.Closes #1708
Evidence
cargo test --test triage_run triage_files_by_defaultfailed becausetriagerequired--recommend-only.After: all ten Triage CLI cases pass, covering filing, flag/config readiness, split Reports, cross-links, provenance, failure notifications and recommendation-only behavior.
cargo test --bin thirdshift setup::tests::on_a_terminal_pressing_enter_throughout_keeps_an_existing_user_config -- --exactpasses with the complete config fixture's new readiness setting preserved.RUST_TEST_THREADS=3 cargo test --test setup: 35 passed, 1 fixture entry point ignored; verifies saved defaults and config section order.e3800c61is green:cargo nextest runpassed 3,644 tests, with 76 skipped. Execution took 843.783s, plus 47.95s compiling the crate. Formatting, Clippy, Console and site checks also passed.scripts/affected-tests issue-1323ran with three test threads and a temporary test HOME: 61 site tests passed (89.58s) and 1,622 unit tests passed (302.51s, warm build). Its redundant integration-test remainder was stopped after matching-head CI passed, followingdocs/testing.md.Test seams
thirdshift triageCLI with a Report, fake Harness and fake GitHub: published issues, labels, cross-links, stdout, Run notification and Command record.Review
Fixed point:
issue-1323(84135240). Standards raised two duplication findings, both addressed; Spec raised none. Both axes read 36 changed files, including generated hunks, with no exclusions. Unread by both axes:src/setup.rsandtests/setup.rs, subsequent test-only fixture updates adding the new setting to the complete User config preservation case and expected config-section lists. Final coverage: 36 read, 2 unread. The implementing agent inspected those fixture changes and validated their tests.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reverting requires removing
[triage]from configs written by Setup. Issues and cross-link comments already filed remain on GitHub.Blast Radius: Triage
Triage now creates issues by default.
--recommend-onlypreserves the preview workflow, and readiness permission defaults off.Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh