Skip to content

File triaged issues by default - #1716

Merged
JacobStephens2 merged 5 commits into
issue-1323from
issue-1708
Nov 4, 2026
Merged

JacobStephens2 merged 5 commits into
issue-1323from
issue-1708

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Report → read-only investigation
  --recommend-only → recommendation JSON
  default → validate labels and readiness → file and cross-link issues
                                        → JSON + Run notification with every URL

thirdshift adds the AI-generated disclaimer and collapsed verbatim Report with its source. Agent readiness requires --allow-ready-for-agent or [triage] allow_ready_for_agent = true; confirmation needing credentials or production access goes to ready-for-human with its reason.

Closes #1708

Evidence

  • Before: cargo test --test triage_run triage_files_by_default failed because triage required --recommend-only.
    After: all ten Triage CLI cases pass, covering filing, flag/config readiness, split Reports, cross-links, provenance, failure notifications and recommendation-only behavior.
  • Generated manual and prompt checks pass.
  • cargo test --bin thirdshift setup::tests::on_a_terminal_pressing_enter_throughout_keeps_an_existing_user_config -- --exact passes with the complete config fixture's new readiness setting preserved.
  • RUST_TEST_THREADS=3 cargo test --test setup: 35 passed, 1 fixture entry point ignored; verifies saved defaults and config section order.
  • CI on the exact head e3800c61 is green: cargo nextest run passed 3,644 tests, with 76 skipped. Execution took 843.783s, plus 47.95s compiling the crate. Formatting, Clippy, Console and site checks also passed.
  • Local scripts/affected-tests issue-1323 ran with three test threads and a temporary test HOME: 61 site tests passed (89.58s) and 1,622 unit tests passed (302.51s, warm build). Its redundant integration-test remainder was stopped after matching-head CI passed, following docs/testing.md.

Test seams

  • Real thirdshift triage CLI with a Report, fake Harness and fake GitHub: published issues, labels, cross-links, stdout, Run notification and Command record.

Review

Fixed point: issue-1323 (84135240). Standards raised two duplication findings, both addressed; Spec raised none. Both axes read 36 changed files, including generated hunks, with no exclusions. Unread by both axes: src/setup.rs and tests/setup.rs, subsequent test-only fixture updates adding the new setting to the complete User config preservation case and expected config-section lists. Final coverage: 36 read, 2 unread. The implementing agent inspected those fixture changes and validated their tests.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Reverting requires removing [triage] from configs written by Setup. Issues and cross-link comments already filed remain on GitHub.

Blast Radius: Triage

Triage now creates issues by default. --recommend-only preserves the preview workflow, and readiness permission defaults off.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit ce7a996 into issue-1323 Nov 4, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1708 branch November 4, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant