Skip to content

Add recommendation-only Triage runs for Reports - #1714

Merged
JacobStephens2 merged 4 commits into
issue-1323from
issue-1707
Nov 4, 2026
Merged

JacobStephens2 merged 4 commits into
issue-1323from
issue-1707

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Report (stdin or --file)
  → Triage run in a throwaway worktree
  → recommendation on stdout and in the Run notification

Closes #1707

Test seams: the real thirdshift triage --recommend-only CLI in a Scenario, with fake GitHub and Harness sessions; observe input delivery, stdout, GitHub state, Command records, Activity log, status and Run notifications.

Evidence

  • Before: cargo test --test triage_run failed because triage was not a recognized command (exit 2).
    After: all six Triage CLI integration tests pass, covering file/stdin delivery, recommendations, GitHub state, Command records, Activity log, status, cleanup, overlapping runs and emailed notifications.
  • Prompt generation: all 13 checks pass. cargo fmt --check and cargo clippy --all-targets -- -D warnings pass.
  • The seventh workflow initially exceeded the existing tablet height budget; the retained browser regression now passes at 320, 390, 768 and 1280 pixels after adjusting summary padding.
  • Adding the command initially exceeded the existing 68-line help budget. Help now retains every explicit command example within that budget. cargo test --test command_surface passes all 20 tests; the original compactness and command-listing checks are retained.
  • Final validation: CARGO_BUILD_JOBS=4 NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 scripts/affected-tests issue-1323 passes: all 61 site tests (63.23s) and the full Rust suite via cargo test (2312.91s, compilation included, three test threads).

Independent thirdshift-code-review against issue-1323: Standards 0, Spec 0. Each axis read all 33 changed files, including generated changes. No changed file was left unread; no generated output was excluded.

Merge Danger

Door: two-way

Blast Radius: Commands

Adds the recommendation-only CLI and Triage recording; sessions use the existing trusted Harness with read-only investigation instructions.

Unaddressed findings

  • Standards: None; the reviewer raised no findings.
  • Spec: None; the reviewer raised no findings.
  • Security: None; the review raised no introduced findings.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.

@JacobStephens2
JacobStephens2 merged commit 8711c01 into issue-1323 Nov 4, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1707 branch November 4, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant