Repository navigation
Add recommendation-only Triage runs for Reports - #1714
Merged
Merged
Conversation
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1707
Test seams: the real
thirdshift triage --recommend-onlyCLI in a Scenario, with fake GitHub and Harness sessions; observe input delivery, stdout, GitHub state, Command records, Activity log, status and Run notifications.Evidence
cargo test --test triage_runfailed becausetriagewas not a recognized command (exit 2).After: all six Triage CLI integration tests pass, covering file/stdin delivery, recommendations, GitHub state, Command records, Activity log, status, cleanup, overlapping runs and emailed notifications.
cargo fmt --checkandcargo clippy --all-targets -- -D warningspass.cargo test --test command_surfacepasses all 20 tests; the original compactness and command-listing checks are retained.CARGO_BUILD_JOBS=4 NEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 scripts/affected-tests issue-1323passes: all 61 site tests (63.23s) and the full Rust suite viacargo test(2312.91s, compilation included, three test threads).Independent
thirdshift-code-reviewagainstissue-1323: Standards 0, Spec 0. Each axis read all 33 changed files, including generated changes. No changed file was left unread; no generated output was excluded.Merge Danger
Door: two-way
Blast Radius: Commands
Adds the recommendation-only CLI and Triage recording; sessions use the existing trusted Harness with read-only investigation instructions.
Unaddressed findings
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.