Repository navigation
Add recommend-only pull request Review runs - #1713
Merged
Merged
Conversation
A pull request can commit .thirdshift-review-input.md as a symlink. Writing the review packet followed that link and replaced a file outside the worktree, then continued the review. Refuse the symlink before a session starts.
The new review-run Built-in process is included in the compiled catalog, but the listing test still expected only the previous four built-ins. Include its name and description in both exact sorted-output assertions.
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review an existing pull request without changing its branch.
Linked closing issues supply the Spec; a body-only review says so. PR discussion, inline and review comments are filtered to Trusted accounts. The Built-in Process can be inspected, checked and copied into a Custom pull-request Process. Manual, site and generated prompt documentation are updated.
Closes #1702
Evidence
review; recommendation cleanup could delete an existing local head branch.After:
cargo test --test review_runpasses all 8 tests, covering eligibility, filtered input, comments, records, notification, Inbox, changed PRs, retained unexpected edits and local branch preservation.retained Step result: false; later session received result path: false.After:
cargo test --test review_run custom_pr_steps_keep_results_and_pass_their_paths_to_later_sessions -- --exact --nocapturepasses. The regression is kept, and both executors share result retention, Step completion and prior-result prompt construction.cargo clippy --all-targets -- -D warningspassed during implementation;cargo fmt --checkpasses after this repair.cargo test --test process process_lists_custom_processes_with_their_descriptions -- --exactfailed because both exact listing expectations omitted the newreview-runBuilt-in process.After: both expectations include its name and description in sorted order, retaining exact equality. The same test passes;
cargo nextest run --test process --test review_run --test-threads 3passes all 244 tests (276.97s). All 61 site tests pass (94.93s).CI notes
Local full Rust validation is blocked by this host's exhausted inotify watches: three unchanged Console account-revocation tests also fail single-threaded on
issue-706(84135240) with identicalOS file watch limit reachedwarnings and assertions, because the 60-second polling fallback exceeds their deadlines. The failures areaccounts::an_open_inbox_stream_closes_when_its_session_is_revoked,accounts::an_open_log_stream_closes_when_its_session_is_revokedandaccounts::cli_and_allowlist_changes_revoke_http_sessions_without_deleting_the_account.Evidence:
NEXTEST_TEST_THREADS=3 scripts/affected-tests issue-706passed all 61 site tests, then stopped with 260 Rust tests passed and these 3 failures (332.88s including compilation). Each failure was reproduced on the base in an isolated checkout usingcargo nextest run --test console --test-threads 1with filters for those tests.git diff issue-706...HEAD -- src/console.rs src/console tests/console.rs tests/consoleis empty; no Console code or tests were changed.Test seams
status/Inbox output.Unaddressed findings
Standards
None. The one finding was reproduced and fixed.
Spec
None. No findings were raised.
Security
None. The review input symlink was reproduced and fixed before a session could start.
Security review outcome
No unaddressed introduced findings.
Review coverage
Both independent axes reviewed the implementation, including generated output; follow-up review accepted the finding's corrections. This CI repair updates only the exact Process-listing expectations in
tests/process.rs, verified by all 244 Process and Review tests. Reports and{"standards":1,"spec":0}are retained with the Session review artifacts.Merge Danger
Door: two-way
Blast Radius: Processes
Adds a CLI workflow and shared Process result handling. Worktree cleanup preserves pre-existing local PR branches; a recommendation never pushes branch changes.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh