Skip to content

Wait for killed child Ticket run to enter died state in status test - #1692

Merged
JacobStephens2 merged 1 commit into
mainfrom
ci-green
Nov 3, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
ci-green

Conversation

@JacobStephens2

Copy link
Copy Markdown
Owner

Summary

     let killed = pid.is_some_and(|pid| {
         std::process::Command::new("kill")
             .args(["-KILL", &pid.to_string()])
             .status()
             .unwrap()
             .success()
     });
-    let after = scenario.run(&["status", "--json"]);
+    let deadline = std::time::Instant::now() + WAIT_BOUND;
+    let after = loop {
+        let json = scenario.run(&["status", "--json"]);
+        let status: serde_json::Value = serde_json::from_str(&json.stdout).unwrap();
+        if status["commands"][0]["children"][0]["state"] == "died"
+            || std::time::Instant::now() >= deadline
+        {
+            break status;
+        }
+        std::thread::sleep(std::time::Duration::from_millis(20));
+    };

Evidence

  • Before: CI run 41619958404 (test-linux-arm) failed at tests/spec_run.rs:241:5 (left: String("live"), right: "died") because kill -KILL returns before the kernel finishes tearing down the process (Z/X or gone in /proc/<pid>/stat).
    After: cargo test --test spec_run status_keeps_concurrent_ticket_runs_separate_and_detects_a_killed_child passes (1 passed; 0 failed).

Merge Danger

Door: two-way

Blast Radius: tiny

@JacobStephens2
JacobStephens2 merged commit db03915 into main Nov 3, 2026
4 checks passed
@JacobStephens2
JacobStephens2 deleted the ci-green branch November 3, 2026 21:35
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant