Repository navigation
Refuse an Architect idea outside the origin repository - #1689
Merged
Merged
Conversation
An Architecture review that names an idea it filed, or an issue that already covers its recommendation, is refused unless that issue is in the repository at origin. The check happens before the issue is viewed or labelled. An issue in that repository still receives needs-triage and architect-idea, including one created before the run.
The architecture page still said every idea ends that catalogue Step successfully. An idea outside the repository at origin is refused before it is viewed or labelled.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An Architect idea is labelled only when that issue is in the repository at origin. That includes an already-filed issue created before the Architect run. An issue outside that repository fails the review with
the issue <url> is not in the repository at origin <origin>. The Architect command and thearchitecture-reviewcatalogue Step shareconclude, so both refuse beforegh issue viewor a label edit.Evidence
architect::tests::an_idea_outside_the_origin_repository_is_refused_before_it_is_viewed_or_labelledfinishedOkwithno Strong candidate: the Architecture review filed the idea https://github.com/other/widgets/issues/8.label_ideahad viewed and labelled the foreign URL.After: the same test expects that origin error and an empty GitHub call list, for both
Architecture review idea:andArchitecture review already filed:.scripts/affected-tests mainpassed:npm test --prefix site(90.47s) andcargo nextest run(3634 passed, 75 skipped, 2076.672s).cargo clippy --all-targets -- -D warningsexited 0.Merge Danger
Door: two-way
Reverting the commits restores the previous labelling path.
Blast Radius: Architect conclusion
A foreign idea URL is no longer viewed or labelled, and its title no longer enters the run notification. An idea in the repository at origin still receives
needs-triageandarchitect-ideain one edit that keeps its other labels, including when it was created before the run. Plan checks are unchanged: a plan must still be open, created since the Architect run started, and free of an unready label.Tests
Seams, named here only:
concludeinsrc/architect.rs(architect::tests),tests/architect_run.rs, andtests/process/architecture_review.rs.Unaddressed findings
None. Standards and Spec each raised the catalogue-Step sentence in
site/architecture/index.htmlthat still said every Architect idea ends the Process successfully. That sentence now says an idea in the repository at origin ends successfully, and an idea outside that repository is refused before it is viewed or labelled (3ae52ecb).Security review outcome
No unaddressed introduced findings.
Review coverage
site/docs/index.htmlwas intentionally not read. It is generated fromdocs/guide.mdbysite/generate-docs.mjs, andnpm run docs:check --prefix siteexited 0. No other changed file was left unread.Closes #1688
Built with grok grok 1.0.70 (f50904eaee6c) [stable] · default model · default effort