Skip to content

Refuse an Architect idea outside the origin repository - #1689

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-1688
Nov 3, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-1688

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

conclude
  Report::Idea or Report::AlreadyFiled
    label_idea
      if the issue is not in the repository at origin
        fail the review before a view or a label edit
      else
        add needs-triage and architect-idea, keeping the other labels

An Architect idea is labelled only when that issue is in the repository at origin. That includes an already-filed issue created before the Architect run. An issue outside that repository fails the review with the issue <url> is not in the repository at origin <origin>. The Architect command and the architecture-review catalogue Step share conclude, so both refuse before gh issue view or a label edit.

Evidence

  • Before: architect::tests::an_idea_outside_the_origin_repository_is_refused_before_it_is_viewed_or_labelled finished Ok with no Strong candidate: the Architecture review filed the idea https://github.com/other/widgets/issues/8. label_idea had viewed and labelled the foreign URL.
    After: the same test expects that origin error and an empty GitHub call list, for both Architecture review idea: and Architecture review already filed:. scripts/affected-tests main passed: npm test --prefix site (90.47s) and cargo nextest run (3634 passed, 75 skipped, 2076.672s). cargo clippy --all-targets -- -D warnings exited 0.

Merge Danger

Door: two-way

Reverting the commits restores the previous labelling path.

Blast Radius: Architect conclusion

A foreign idea URL is no longer viewed or labelled, and its title no longer enters the run notification. An idea in the repository at origin still receives needs-triage and architect-idea in one edit that keeps its other labels, including when it was created before the run. Plan checks are unchanged: a plan must still be open, created since the Architect run started, and free of an unready label.

Tests

Seams, named here only: conclude in src/architect.rs (architect::tests), tests/architect_run.rs, and tests/process/architecture_review.rs.

Unaddressed findings

None. Standards and Spec each raised the catalogue-Step sentence in site/architecture/index.html that still said every Architect idea ends the Process successfully. That sentence now says an idea in the repository at origin ends successfully, and an idea outside that repository is refused before it is viewed or labelled (3ae52ecb).

Security review outcome

No unaddressed introduced findings.

Review coverage

site/docs/index.html was intentionally not read. It is generated from docs/guide.md by site/generate-docs.mjs, and npm run docs:check --prefix site exited 0. No other changed file was left unread.

Closes #1688

Built with grok grok 1.0.70 (f50904eaee6c) [stable] · default model · default effort

An Architecture review that names an idea it filed, or an issue that already covers its recommendation, is refused unless that issue is in the repository at origin. The check happens before the issue is viewed or labelled. An issue in that repository still receives needs-triage and architect-idea, including one created before the run.
The architecture page still said every idea ends that catalogue Step successfully. An idea outside the repository at origin is refused before it is viewed or labelled.
@JacobStephens2
JacobStephens2 merged commit 6b1797a into main Nov 3, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1688 branch November 3, 2026 10:31
@JacobStephens2 JacobStephens2 mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refuse an Architect idea outside the origin repository

1 participant