Skip to content

Keep Other-account Process Steps inside the accepted log directory - #1687

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-1686
Nov 2, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-1686

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

show / Console peek
  process_steps(command log, accepted log directory)
    steps_command_log
      serving account → read the given path
      Other account → canonicalize
        stays under the accepted log directory → open that canonical path
        leaves it → print no Steps

show and the Console print a Process's Steps from its Command log. For an Other-account Command, they read that log only when its canonical path stays under the accepted log directory, and they open that canonical path.

Seam: thirdshift show <command> and Console /peek?command= for an Other-account Process.

Evidence

  • Before: cargo test --test console other_accounts::other_account_process_steps_stay_under_their_accepted_log_directory -- --exact failed at tests/console/other_accounts.rs:823. show widgets#7 printed step CANARY-ESCAPED-STEP: 1s succeeded from a Command log symlinked outside the accepted log directory.
    After: the same test passes. show widgets#8 and /peek?command=widgets%238 print INSIDE-ACCEPTED-STEP when the canonical path stays inside. scripts/affected-tests main passed: npm test --prefix site (79.55s), npm test --prefix console (119.98s), and cargo nextest run (2163.15s; 3632 passed, 75 skipped).

Merge Danger

Door: two-way

Revert the commit. Nothing on disk is rewritten. The accepted directory rides with the Console inspection and is not stored in a Command record.

Blast Radius: Other-account Process Steps

An Other-account Process whose Command log leaves the accepted log directory prints no Steps. The serving account reads the given path. A Step result path is the lexical {log}.steps/{name}.txt when that file exists.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Review coverage

The review left no changed file unread.

site/docs/index.html was intentionally not read as source. It is generated from docs/guide.md by site/generate-docs.mjs. Standards re-ran npm run docs:check --prefix site (exit 0). Spec inspected the hunk: the new Process Step sentence, HTML-escaped, in the Other local accounts paragraph. site/architecture/index.html was reviewed as a hand-written page.

Closes #1686

Built with grok grok 1.0.70 (f50904eaee6c) [stable] · default model · default effort

show and the Console print a Process's Steps from its Command log. For an Other-account Command, open that log only when its canonical path stays under the accepted log directory, and read the canonical path.
@JacobStephens2
JacobStephens2 merged commit 5af28b8 into main Nov 2, 2026
16 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1686 branch November 2, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep Other-account Process Steps inside the accepted log directory

1 participant