Repository navigation
Keep Other-account Process Steps inside the accepted log directory - #1687
Merged
Merged
Conversation
show and the Console print a Process's Steps from its Command log. For an Other-account Command, open that log only when its canonical path stays under the accepted log directory, and read the canonical path.
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showand the Console print a Process's Steps from its Command log. For an Other-account Command, they read that log only when its canonical path stays under the accepted log directory, and they open that canonical path.Seam:
thirdshift show <command>and Console/peek?command=for an Other-account Process.Evidence
cargo test --test console other_accounts::other_account_process_steps_stay_under_their_accepted_log_directory -- --exactfailed attests/console/other_accounts.rs:823.show widgets#7printedstep CANARY-ESCAPED-STEP: 1s succeededfrom a Command log symlinked outside the accepted log directory.After: the same test passes.
show widgets#8and/peek?command=widgets%238printINSIDE-ACCEPTED-STEPwhen the canonical path stays inside.scripts/affected-tests mainpassed:npm test --prefix site(79.55s),npm test --prefix console(119.98s), andcargo nextest run(2163.15s; 3632 passed, 75 skipped).Merge Danger
Door: two-way
Revert the commit. Nothing on disk is rewritten. The accepted directory rides with the Console inspection and is not stored in a Command record.
Blast Radius: Other-account Process Steps
An Other-account Process whose Command log leaves the accepted log directory prints no Steps. The serving account reads the given path. A Step result path is the lexical
{log}.steps/{name}.txtwhen that file exists.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Review coverage
The review left no changed file unread.
site/docs/index.htmlwas intentionally not read as source. It is generated fromdocs/guide.mdbysite/generate-docs.mjs. Standards re-rannpm run docs:check --prefix site(exit 0). Spec inspected the hunk: the new Process Step sentence, HTML-escaped, in the Other local accounts paragraph.site/architecture/index.htmlwas reviewed as a hand-written page.Closes #1686
Built with grok grok 1.0.70 (f50904eaee6c) [stable] · default model · default effort