Repository navigation
Keep an Other-account Session trace inside its Command record - #1683
Merged
Merged
Conversation
Reject a trace when the canonical path of its log records or spans leaves the directory that holds that Command record. A lexical prefix still follows a directory symlink.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An Other-account Command's Session trace is kept only when its log records and its spans are regular files whose canonical paths stay inside the directory that holds that Command record. A lexical prefix still follows a directory symlink.
Seam:
thirdshift show <command> --spansfor an Other-account Command.Evidence
show widgets#8 --spans --jsonincludedCANARY-ESCAPED-SESSIONfrom a trace reached through a directory symlink inside the Command record directory.show widgets#9 --spans --jsonincludedCANARY-SIDECAR-SESSIONfrom a spans file that was a symlink out of that directory.After:
cargo test --test console other_account_session_traces_stay_inside_their_command_record_directoryandcargo test --test console other_account_session_trace_sidecars_stay_inside_their_command_record_directorypass. A regular trace in that directory (INSIDE-COMMAND-DIRECTORY) is still shown.scripts/affected-tests mainpassed:npm test --prefix site(72.94s) andcargo nextest run(2104.35s).Merge Danger
Door: two-way
The new check only drops a Session trace while reading another account. Reverting the commit restores the previous read. Nothing is written to the other account.
Blast Radius: other-account reads
The serving account's own Commands are unchanged. An Other-account Session trace whose canonical path leaves its Command record directory is no longer shown, exported, or used for signals.
Unaddressed findings
None. Standards and Spec reported no findings.
Security review outcome
No unaddressed introduced findings.
Review coverage
site/docs/index.htmlwas not read as source. It is generated fromdocs/guide.mdbysite/generate-docs.mjs.npm run docs --prefix siteandnpm run docs:check --prefix siteboth exited 0.site/architecture/index.htmlwas reviewed as a hand-written page.Closes #1682
Built with grok grok 1.0.70 (f50904eaee6c) [stable] · default model · default effort