Repository navigation
Fix release publication ordering and recovery - #1675
Merged
Merged
Conversation
A failed gh release view was treated as no GitHub Release, so resuming release.sh force-pushed a published tag. Only the not-found result may move an unpublished tag; any other lookup refuses and leaves the refs in place.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-cuts refresh the bump PR and retain the prior release boundary for summaries and optional Experiments. Published releases keep their refs.
Closes #1674
Evidence
Before: The release failure regression reported
MERGEDinstead ofOPEN. Both Spec reproductions exited 1: recovery consumed a stale failed attempt, and old merged-bump summaries omitted original release changes.After: The ordering, stale-attempt, summary and Experiment Baseline regressions pass.
scripts/affected-tests mainpassed: 60 site tests, 3,626 Rust tests (75 skipped), and 3 release-generator tests. All GitHub checks are green on14c6fea1.Full Rust command:
cargo nextest run, selected byNEXTEST_TEST_THREADS=3 RUST_TEST_THREADS=3 CARGO_BUILD_JOBS=3 scripts/affected-tests main; 2,902.84s including compilation, with three workers. Site checks took 85.19s; generator checks took 1.48s. Total selector wall time: 2,989.77s.Seams under test:
scripts/release.shinvoked as a black box against the release integration fixture's local origin, fake GitHub CLI, and Harness/Experiment adapters; thethirdshift experiment --releasecommand's Baseline selection.Review coverage
Standards raised 1 finding; Spec raised 2. All addressed, including the shared failed-release fixture setup. Both axes inspected every changed file, including generated manual hunks. Unread changed files: none. Generated-output exclusions: none.
Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: releases
Recovery force-updates unpublished release branch/tag refs. Publication checks guard both updates; failed release workflows leave the bump PR open.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh